* [LTP] [PATCH] semctl09: Fix heap smash
@ 2021-01-15 15:19 Martin Doucha
2021-01-18 9:10 ` Yang Xu
0 siblings, 1 reply; 2+ messages in thread
From: Martin Doucha @ 2021-01-15 15:19 UTC (permalink / raw)
To: ltp
semctl() expects pointer to a buffer as its fourth argument, not pointer
to a pointer. Passing &un.buf results in heap smash that corrupts internal
LTP data structures on some archs.
CC: Feiyu Zhu <zhufy.jy@cn.fujitsu.com>
Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
testcases/kernel/syscalls/ipc/semctl/semctl09.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/ipc/semctl/semctl09.c b/testcases/kernel/syscalls/ipc/semctl/semctl09.c
index 131bfbc07..d36ba62e5 100644
--- a/testcases/kernel/syscalls/ipc/semctl/semctl09.c
+++ b/testcases/kernel/syscalls/ipc/semctl/semctl09.c
@@ -51,11 +51,15 @@ static union semun un;
*/
static inline int do_semctl(int semid, int semnum, int cmd)
{
+ struct semid_ds info;
+
+ un.buf = &info;
+
switch (tst_variant) {
case 0:
- return tst_syscall(__NR_semctl, semid, semnum, cmd, &un.buf);
+ return tst_syscall(__NR_semctl, semid, semnum, cmd, un);
case 1:
- return semctl(semid, semnum, cmd, &un.buf);
+ return semctl(semid, semnum, cmd, un);
}
return -1;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [LTP] [PATCH] semctl09: Fix heap smash
2021-01-15 15:19 [LTP] [PATCH] semctl09: Fix heap smash Martin Doucha
@ 2021-01-18 9:10 ` Yang Xu
0 siblings, 0 replies; 2+ messages in thread
From: Yang Xu @ 2021-01-18 9:10 UTC (permalink / raw)
To: ltp
Hi Martin
LGTM, pushed. Thanks.
Best Regards
Yang Xu
> semctl() expects pointer to a buffer as its fourth argument, not pointer
> to a pointer. Passing&un.buf results in heap smash that corrupts internal
> LTP data structures on some archs.
>
> CC: Feiyu Zhu<zhufy.jy@cn.fujitsu.com>
> Signed-off-by: Martin Doucha<mdoucha@suse.cz>
> ---
> testcases/kernel/syscalls/ipc/semctl/semctl09.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/ipc/semctl/semctl09.c b/testcases/kernel/syscalls/ipc/semctl/semctl09.c
> index 131bfbc07..d36ba62e5 100644
> --- a/testcases/kernel/syscalls/ipc/semctl/semctl09.c
> +++ b/testcases/kernel/syscalls/ipc/semctl/semctl09.c
> @@ -51,11 +51,15 @@ static union semun un;
> */
> static inline int do_semctl(int semid, int semnum, int cmd)
> {
> + struct semid_ds info;
> +
> + un.buf =&info;
> +
> switch (tst_variant) {
> case 0:
> - return tst_syscall(__NR_semctl, semid, semnum, cmd,&un.buf);
> + return tst_syscall(__NR_semctl, semid, semnum, cmd, un);
> case 1:
> - return semctl(semid, semnum, cmd,&un.buf);
> + return semctl(semid, semnum, cmd, un);
> }
> return -1;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-18 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-15 15:19 [LTP] [PATCH] semctl09: Fix heap smash Martin Doucha
2021-01-18 9:10 ` Yang Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox