[LTP] [PATCH] sendfile09: skip on native 32-bit kernels

[LTP] [PATCH] sendfile09: skip on native 32-bit kernels

[Avinesh Kumar via ltp]

this test is already documented as 64-bit only, but
.skip_in_compat only covers 32-bit-on-64-bit. On a native 32-bit
kernel (e.g. i586) it still runs and setup's write() past 2GB fails
with EFBIG (TBROK).

sendfile09.c:49: TBROK: write(3,0x4a8011,1) failed: EFBIG (27)

TCONF on 32-bit kernels via tst_kernel_bits().

Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
---
 testcases/kernel/syscalls/sendfile/sendfile09.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/testcases/kernel/syscalls/sendfile/sendfile09.c b/testcases/kernel/syscalls/sendfile/sendfile09.c
index 82feaeba0..50b9c1ca7 100644
--- a/testcases/kernel/syscalls/sendfile/sendfile09.c
+++ b/testcases/kernel/syscalls/sendfile/sendfile09.c
@@ -40,6 +40,9 @@ static void setup(void)
 {
 	int i, fd;
 
+	if (tst_kernel_bits() == 32)
+		tst_brk(TCONF, "Test is only supported on 64-bit kernels");
+
 	if (!tst_fs_has_free(".", 5, TST_GB))
 		tst_brk(TCONF, "Test on large file needs 5G free space");
 
-- 
2.54.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] sendfile09: skip on native 32-bit kernels

[linuxtestproject.agent]

Hi Avinesh,

On Tue, 23 Jun 2026, Avinesh Kumar wrote:
> sendfile09: skip on native 32-bit kernels

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH v2] sendfile09: skip on native 32-bit kernels

[Avinesh Kumar via ltp]

this test is already documented as 64-bit only, but
.skip_in_compat only covers 32-bit-on-64-bit. On a native 32-bit
kernel (e.g. i586) it still runs and setup's write() past 2GB fails
with EFBIG (TBROK).

sendfile09.c:49: TBROK: write(3,0x4a8011,1) failed: EFBIG (27)

switch to ".needs_abi_bits = 64" to cover both scenarios.

Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
---
Changes in v2:
- Use .needs_abi_bits field
---
 testcases/kernel/syscalls/sendfile/sendfile09.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/syscalls/sendfile/sendfile09.c b/testcases/kernel/syscalls/sendfile/sendfile09.c
index 82feaeba0..7e030db4a 100644
--- a/testcases/kernel/syscalls/sendfile/sendfile09.c
+++ b/testcases/kernel/syscalls/sendfile/sendfile09.c
@@ -92,7 +92,7 @@ static struct tst_test test = {
 	.test = run,
 	.tcnt = ARRAY_SIZE(tc),
 	.timeout = 120,
-	.skip_in_compat = 1,
+	.needs_abi_bits = 64,
 	.tags = (const struct tst_tag[]) {
 		{"linux-git", "5d73320a96fcc"},
 		{}
-- 
2.54.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] sendfile09: skip on native 32-bit kernels

[linuxtestproject.agent]

Hi Avinesh,

On Tue, 23 Jun 2026 21:46:09 +0200, Avinesh Kumar wrote:
> sendfile09: skip on native 32-bit kernels

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] sendfile09: skip on native 32-bit kernels

[Andrea Cervesato via ltp]

Hi Avinesh,

this seems to be a common pattern. Did you see this repeating for
other tests which are skipping compat mode?

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] sendfile09: skip on native 32-bit kernels

[Andrea Cervesato via ltp]

Hi Avinesh,

> +	if (tst_kernel_bits() == 32)
> +		tst_brk(TCONF, "Test is only supported on 64-bit kernels");

Why not .needs_abi_bits == 64?

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp