* [LTP] [PATCH] set_mempolicy05: require CONFIG_NUMA @ 2026-06-23 12:48 Avinesh Kumar via ltp 2026-06-23 15:51 ` [LTP] " linuxtestproject.agent 2026-06-24 8:14 ` [LTP] [PATCH] " Andrea Cervesato via ltp 0 siblings, 2 replies; 9+ messages in thread From: Avinesh Kumar via ltp @ 2026-06-23 12:48 UTC (permalink / raw) To: ltp On kernels without CONFIG_NUMA=y set_mempolicy() returns ENOSYS, which the test misreports as TFAIL. set_mempolicy05.c:105: TFAIL: set_mempolicy should fail with EFAULT or EINVAL, instead returned 38 Add .needs_kconfigs with CONFIG_NUMA=y Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com> --- testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c index 65061bf3d..6c91beebc 100644 --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c @@ -115,6 +115,10 @@ static struct tst_test test = { "ppc", NULL }, + .needs_kconfigs = (const char *const[]){ + "CONFIG_NUMA=y", + NULL + }, .tags = (const struct tst_tag[]) { {"linux-git", "cf01fb9985e8"}, {"CVE", "CVE-2017-7616"}, -- 2.54.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [LTP] set_mempolicy05: require CONFIG_NUMA 2026-06-23 12:48 [LTP] [PATCH] set_mempolicy05: require CONFIG_NUMA Avinesh Kumar via ltp @ 2026-06-23 15:51 ` linuxtestproject.agent 2026-06-24 8:14 ` [LTP] [PATCH] " Andrea Cervesato via ltp 1 sibling, 0 replies; 9+ messages in thread From: linuxtestproject.agent @ 2026-06-23 15:51 UTC (permalink / raw) To: Avinesh Kumar; +Cc: ltp Hi Avinesh, On 23 Jun 2026, Avinesh Kumar wrote: > set_mempolicy05: require CONFIG_NUMA Verdict - Reviewed --- Note: The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions. Regards, LTP AI Reviewer -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] set_mempolicy05: require CONFIG_NUMA 2026-06-23 12:48 [LTP] [PATCH] set_mempolicy05: require CONFIG_NUMA Avinesh Kumar via ltp 2026-06-23 15:51 ` [LTP] " linuxtestproject.agent @ 2026-06-24 8:14 ` Andrea Cervesato via ltp 2026-06-24 15:41 ` Avinesh Kumar via ltp 1 sibling, 1 reply; 9+ messages in thread From: Andrea Cervesato via ltp @ 2026-06-24 8:14 UTC (permalink / raw) To: Avinesh Kumar via ltp; +Cc: ltp Hi Avinesh, the patch looks good to me, but it's probably not enough. we will need to implement the same concept for all set_mempolicy() tests, since it's NUMA specific. We just missed this for all this time apparently. Did you see the same errors for them as well? Regards, -- Andrea Cervesato SUSE QE Automation Engineer Linux andrea.cervesato@suse.com -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] set_mempolicy05: require CONFIG_NUMA 2026-06-24 8:14 ` [LTP] [PATCH] " Andrea Cervesato via ltp @ 2026-06-24 15:41 ` Avinesh Kumar via ltp 2026-06-25 7:01 ` Andrea Cervesato via ltp 0 siblings, 1 reply; 9+ messages in thread From: Avinesh Kumar via ltp @ 2026-06-24 15:41 UTC (permalink / raw) To: Andrea Cervesato; +Cc: Linux Test Project Hi Andrea, On 6/24/26 10:14 AM, Andrea Cervesato via ltp wrote: > Hi Avinesh, > > the patch looks good to me, but it's probably not enough. we will > need to implement the same concept for all set_mempolicy() tests, > since it's NUMA specific. We just missed this for all this time > apparently. Did you see the same errors for them as well? Thanks for the review. Remaining set_mempolicy tests are checking for minimum two NUMA nodes and hence reports tse_numa.c:200: TINFO: Found 1 NUMA memory nodes tse_numa.c:141: TINFO: File '/sys/devices/system/node/node0/meminfo' does not exist! NUMA not enabled? get_mempolicy02.c:60: TCONF: test requires at least one NUMA memory node even on systems without CONFIG_NUMA=y. But I also think that we should add CONFIG_NUMA=y check in all these tests. Please confirm, I will send revised version. Regards, Avinesh -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH] set_mempolicy05: require CONFIG_NUMA 2026-06-24 15:41 ` Avinesh Kumar via ltp @ 2026-06-25 7:01 ` Andrea Cervesato via ltp 2026-06-25 14:57 ` [LTP] [PATCH v2] set_mempolicy: " Avinesh Kumar via ltp 0 siblings, 1 reply; 9+ messages in thread From: Andrea Cervesato via ltp @ 2026-06-25 7:01 UTC (permalink / raw) To: Avinesh Kumar; +Cc: Linux Test Project > But I also think that we should add > CONFIG_NUMA=y check in all these tests. Please confirm, I will send > revised version. Yes please, let's fix them all already. Thanks, -- Andrea Cervesato SUSE QE Automation Engineer Linux andrea.cervesato@suse.com -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 9+ messages in thread
* [LTP] [PATCH v2] set_mempolicy: require CONFIG_NUMA 2026-06-25 7:01 ` Andrea Cervesato via ltp @ 2026-06-25 14:57 ` Avinesh Kumar via ltp 2026-06-26 9:13 ` Andrea Cervesato via ltp 0 siblings, 1 reply; 9+ messages in thread From: Avinesh Kumar via ltp @ 2026-06-25 14:57 UTC (permalink / raw) To: ltp From: Avinesh Kumar <avinesh.kumar@suse.com> On kernels without CONFIG_NUMA=y set_mempolicy() returns ENOSYS, which the test misreports as TFAIL. set_mempolicy05 - set_mempolicy05.c:105: TFAIL: set_mempolicy should fail with EFAULT or EINVAL, instead returned 38 remaining of these tests (set_mempolicy[01-04]) checks for minimum two NUMA nodes and reports TCONF, but those also should exit on CONFIG_NUMA check. tse_numa.c:200: TINFO: Found 1 NUMA memory nodes tse_numa.c:141: TINFO: File '/sys/devices/system/node/node0/meminfo' does not exist! NUMA not enabled? get_mempolicy02.c:60: TCONF: test requires at least one NUMA memory node Add .needs_kconfigs with CONFIG_NUMA=y Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com> --- testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c | 4 ++++ testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c | 4 ++++ testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c | 4 ++++ testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c | 4 ++++ testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c | 4 ++++ 5 files changed, 20 insertions(+) diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c index a85a56332..07836cc69 100644 --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c @@ -120,6 +120,10 @@ static struct tst_test test = { .forks_child = 1, .needs_checkpoints = 1, .timeout = 600, + .needs_kconfigs = (const char *const[]){ + "CONFIG_NUMA=y", + NULL + } }; #else diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c index 94d8aa336..d98f81545 100644 --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c @@ -109,6 +109,10 @@ static struct tst_test test = { .tcnt = 2, .forks_child = 1, .needs_checkpoints = 1, + .needs_kconfigs = (const char *const[]){ + "CONFIG_NUMA=y", + NULL + } }; #else diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c index bc5e03217..43e0439d4 100644 --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c @@ -103,6 +103,10 @@ static struct tst_test test = { .mntpoint = MNTPOINT, .forks_child = 1, .needs_checkpoints = 1, + .needs_kconfigs = (const char *const[]){ + "CONFIG_NUMA=y", + NULL + } }; #else diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c index 672232c84..fa88385ce 100644 --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c @@ -134,6 +134,10 @@ static struct tst_test test = { .all_filesystems = 1, .mntpoint = MNTPOINT, .needs_checkpoints = 1, + .needs_kconfigs = (const char *const[]){ + "CONFIG_NUMA=y", + NULL + } }; #else diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c index 65061bf3d..6c91beebc 100644 --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c @@ -115,6 +115,10 @@ static struct tst_test test = { "ppc", NULL }, + .needs_kconfigs = (const char *const[]){ + "CONFIG_NUMA=y", + NULL + }, .tags = (const struct tst_tag[]) { {"linux-git", "cf01fb9985e8"}, {"CVE", "CVE-2017-7616"}, -- 2.54.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH v2] set_mempolicy: require CONFIG_NUMA 2026-06-25 14:57 ` [LTP] [PATCH v2] set_mempolicy: " Avinesh Kumar via ltp @ 2026-06-26 9:13 ` Andrea Cervesato via ltp 2026-06-26 13:53 ` [LTP] [PATCH v3] " Avinesh Kumar via ltp 0 siblings, 1 reply; 9+ messages in thread From: Andrea Cervesato via ltp @ 2026-06-26 9:13 UTC (permalink / raw) To: Avinesh Kumar via ltp; +Cc: ltp Hi Avinesh, the patch doesn't apply on the main branch. Please send a new patch version. https://github.com/linux-test-project/ltp/actions/runs/28183890018 Regards, -- Andrea Cervesato SUSE QE Automation Engineer Linux andrea.cervesato@suse.com -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 9+ messages in thread
* [LTP] [PATCH v3] set_mempolicy: require CONFIG_NUMA 2026-06-26 9:13 ` Andrea Cervesato via ltp @ 2026-06-26 13:53 ` Avinesh Kumar via ltp 2026-06-26 14:11 ` Wei Gao via ltp 0 siblings, 1 reply; 9+ messages in thread From: Avinesh Kumar via ltp @ 2026-06-26 13:53 UTC (permalink / raw) To: ltp From: Avinesh Kumar <avinesh.kumar@suse.com> On kernels without CONFIG_NUMA=y set_mempolicy() returns ENOSYS, which the test misreports as TFAIL. set_mempolicy05 - set_mempolicy05.c:105: TFAIL: set_mempolicy should fail with EFAULT or EINVAL, instead returned 38 remaining of these tests (set_mempolicy[01-04]) checks for minimum two NUMA nodes and reports TCONF, but those also should exit on CONFIG_NUMA check. tse_numa.c:200: TINFO: Found 1 NUMA memory nodes tse_numa.c:141: TINFO: File '/sys/devices/system/node/node0/meminfo' does not exist! NUMA not enabled? get_mempolicy02.c:60: TCONF: test requires at least one NUMA memory node Add .needs_kconfigs with CONFIG_NUMA=y Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com> --- testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c | 4 ++++ testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c | 4 ++++ testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c | 4 ++++ testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c | 4 ++++ testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c | 4 ++++ 5 files changed, 20 insertions(+) diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c index a85a56332..07836cc69 100644 --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c @@ -120,6 +120,10 @@ static struct tst_test test = { .forks_child = 1, .needs_checkpoints = 1, .timeout = 600, + .needs_kconfigs = (const char *const[]){ + "CONFIG_NUMA=y", + NULL + } }; #else diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c index 94d8aa336..d98f81545 100644 --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c @@ -109,6 +109,10 @@ static struct tst_test test = { .tcnt = 2, .forks_child = 1, .needs_checkpoints = 1, + .needs_kconfigs = (const char *const[]){ + "CONFIG_NUMA=y", + NULL + } }; #else diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c index bc5e03217..43e0439d4 100644 --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c @@ -103,6 +103,10 @@ static struct tst_test test = { .mntpoint = MNTPOINT, .forks_child = 1, .needs_checkpoints = 1, + .needs_kconfigs = (const char *const[]){ + "CONFIG_NUMA=y", + NULL + } }; #else diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c index 672232c84..fa88385ce 100644 --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c @@ -134,6 +134,10 @@ static struct tst_test test = { .all_filesystems = 1, .mntpoint = MNTPOINT, .needs_checkpoints = 1, + .needs_kconfigs = (const char *const[]){ + "CONFIG_NUMA=y", + NULL + } }; #else diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c index 7481dcd8d..fb118c4ac 100644 --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c @@ -115,6 +115,10 @@ static struct tst_test test = { "ppc", NULL }, + .needs_kconfigs = (const char *const[]){ + "CONFIG_NUMA=y", + NULL + }, .tags = (const struct tst_tag[]) { {"linux-git", "cf01fb9985e8"}, {"CVE", "2017-7616"}, -- 2.54.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [LTP] [PATCH v3] set_mempolicy: require CONFIG_NUMA 2026-06-26 13:53 ` [LTP] [PATCH v3] " Avinesh Kumar via ltp @ 2026-06-26 14:11 ` Wei Gao via ltp 0 siblings, 0 replies; 9+ messages in thread From: Wei Gao via ltp @ 2026-06-26 14:11 UTC (permalink / raw) To: Avinesh Kumar; +Cc: ltp On Fri, Jun 26, 2026 at 03:53:46PM +0200, Avinesh Kumar via ltp wrote: > From: Avinesh Kumar <avinesh.kumar@suse.com> > > On kernels without CONFIG_NUMA=y set_mempolicy() returns ENOSYS, > which the test misreports as TFAIL. > > set_mempolicy05 - > > set_mempolicy05.c:105: TFAIL: set_mempolicy should fail with EFAULT or EINVAL, instead returned 38 > > remaining of these tests (set_mempolicy[01-04]) checks for minimum two > NUMA nodes and reports TCONF, but those also should exit on CONFIG_NUMA > check. > > tse_numa.c:200: TINFO: Found 1 NUMA memory nodes > tse_numa.c:141: TINFO: File '/sys/devices/system/node/node0/meminfo' does not exist! NUMA not enabled? > get_mempolicy02.c:60: TCONF: test requires at least one NUMA memory node > > Add .needs_kconfigs with CONFIG_NUMA=y > > Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com> > --- > testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c | 4 ++++ > testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c | 4 ++++ > testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c | 4 ++++ > testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c | 4 ++++ > testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c | 4 ++++ > 5 files changed, 20 insertions(+) > > diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c > index a85a56332..07836cc69 100644 > --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c > +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c > @@ -120,6 +120,10 @@ static struct tst_test test = { > .forks_child = 1, > .needs_checkpoints = 1, > .timeout = 600, > + .needs_kconfigs = (const char *const[]){ > + "CONFIG_NUMA=y", > + NULL > + } > }; I suppose we do not need "#ifdef HAVE_NUMA_V2" anymore in the code. Same for set_mempolicy02 etc > > #else > diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c > index 94d8aa336..d98f81545 100644 > --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c > +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c > @@ -109,6 +109,10 @@ static struct tst_test test = { > .tcnt = 2, > .forks_child = 1, > .needs_checkpoints = 1, > + .needs_kconfigs = (const char *const[]){ > + "CONFIG_NUMA=y", > + NULL > + } > }; > > #else > diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c > index bc5e03217..43e0439d4 100644 > --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c > +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c > @@ -103,6 +103,10 @@ static struct tst_test test = { > .mntpoint = MNTPOINT, > .forks_child = 1, > .needs_checkpoints = 1, > + .needs_kconfigs = (const char *const[]){ > + "CONFIG_NUMA=y", > + NULL > + } > }; > > #else > diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c > index 672232c84..fa88385ce 100644 > --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c > +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c > @@ -134,6 +134,10 @@ static struct tst_test test = { > .all_filesystems = 1, > .mntpoint = MNTPOINT, > .needs_checkpoints = 1, > + .needs_kconfigs = (const char *const[]){ > + "CONFIG_NUMA=y", > + NULL > + } > }; > > #else > diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c > index 7481dcd8d..fb118c4ac 100644 > --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c > +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c > @@ -115,6 +115,10 @@ static struct tst_test test = { > "ppc", > NULL > }, > + .needs_kconfigs = (const char *const[]){ > + "CONFIG_NUMA=y", > + NULL > + }, > .tags = (const struct tst_tag[]) { > {"linux-git", "cf01fb9985e8"}, > {"CVE", "2017-7616"}, > -- > 2.54.0 > > > -- > Mailing list info: https://lists.linux.it/listinfo/ltp -- Mailing list info: https://lists.linux.it/listinfo/ltp ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-06-26 14:12 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-06-23 12:48 [LTP] [PATCH] set_mempolicy05: require CONFIG_NUMA Avinesh Kumar via ltp 2026-06-23 15:51 ` [LTP] " linuxtestproject.agent 2026-06-24 8:14 ` [LTP] [PATCH] " Andrea Cervesato via ltp 2026-06-24 15:41 ` Avinesh Kumar via ltp 2026-06-25 7:01 ` Andrea Cervesato via ltp 2026-06-25 14:57 ` [LTP] [PATCH v2] set_mempolicy: " Avinesh Kumar via ltp 2026-06-26 9:13 ` Andrea Cervesato via ltp 2026-06-26 13:53 ` [LTP] [PATCH v3] " Avinesh Kumar via ltp 2026-06-26 14:11 ` Wei Gao via ltp
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox