* [LTP] [PATCH 1/1] checkpatch: Ignore USE_NEGATIVE_ERRNO
@ 2026-07-10 6:29 Petr Vorel
2026-07-10 8:02 ` Cyril Hrubis
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Petr Vorel @ 2026-07-10 6:29 UTC (permalink / raw)
To: ltp
return of an errno should typically be negative is purely kernel
specific, avoid warning like:
epoll_ctl06.c:36: WARNING: return of an errno should typically be negative (ie: return -EPERM)
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
.checkpatch.conf | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.checkpatch.conf b/.checkpatch.conf
index a7b6219ada..2ede8d54c5 100644
--- a/.checkpatch.conf
+++ b/.checkpatch.conf
@@ -12,6 +12,9 @@
# kernel specific
--ignore BIT_MACRO,PREFER_DEFINED_ATTRIBUTE_MACRO,PREFER_KERNEL_TYPES,STRCPY,STRLCPY,STRNCPY
+# kernel specific (cont)
+--ignore USE_NEGATIVE_ERRNO
+
# TODO: document reason
--ignore CONST_STRUCT,VOLATILE,FILE_PATH_CHANGES,LONG_LINE,MACRO_ARG_REUSE,MULTIPLE_ASSIGNMENTS
--
2.54.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH 1/1] checkpatch: Ignore USE_NEGATIVE_ERRNO
2026-07-10 6:29 [LTP] [PATCH 1/1] checkpatch: Ignore USE_NEGATIVE_ERRNO Petr Vorel
@ 2026-07-10 8:02 ` Cyril Hrubis
2026-07-10 8:25 ` [LTP] " linuxtestproject.agent
2026-07-14 8:20 ` [LTP] [PATCH 1/1] " Andrea Cervesato via ltp
2 siblings, 0 replies; 4+ messages in thread
From: Cyril Hrubis @ 2026-07-10 8:02 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi!
Looks obviously correct.
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] checkpatch: Ignore USE_NEGATIVE_ERRNO
2026-07-10 6:29 [LTP] [PATCH 1/1] checkpatch: Ignore USE_NEGATIVE_ERRNO Petr Vorel
2026-07-10 8:02 ` Cyril Hrubis
@ 2026-07-10 8:25 ` linuxtestproject.agent
2026-07-14 8:20 ` [LTP] [PATCH 1/1] " Andrea Cervesato via ltp
2 siblings, 0 replies; 4+ messages in thread
From: linuxtestproject.agent @ 2026-07-10 8:25 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi Petr,
On Fri, Jul 10, 2026 at 08:29:21 +0200, Petr Vorel wrote:
> checkpatch: Ignore USE_NEGATIVE_ERRNO
Verdict - Reviewed
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH 1/1] checkpatch: Ignore USE_NEGATIVE_ERRNO
2026-07-10 6:29 [LTP] [PATCH 1/1] checkpatch: Ignore USE_NEGATIVE_ERRNO Petr Vorel
2026-07-10 8:02 ` Cyril Hrubis
2026-07-10 8:25 ` [LTP] " linuxtestproject.agent
@ 2026-07-14 8:20 ` Andrea Cervesato via ltp
2 siblings, 0 replies; 4+ messages in thread
From: Andrea Cervesato via ltp @ 2026-07-14 8:20 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-07-14 8:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-10 6:29 [LTP] [PATCH 1/1] checkpatch: Ignore USE_NEGATIVE_ERRNO Petr Vorel
2026-07-10 8:02 ` Cyril Hrubis
2026-07-10 8:25 ` [LTP] " linuxtestproject.agent
2026-07-14 8:20 ` [LTP] [PATCH 1/1] " Andrea Cervesato via ltp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox