[LTP] [PATCH] lib: tst_res(): Fix TDEBUG | TERRNO

[LTP] [PATCH] lib: tst_res(): Fix TDEBUG | TERRNO

[Cyril Hrubis]

Properly mask the ttype with TTYPE_MASK() when deciding if TDEBUG
messages should be printed, otherwise any combination of TERRNO etc.
flags is printed regardless the -D flag.

Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
---
 lib/newlib_tests/tst_res_flags.c | 1 +
 lib/tst_test.c                   | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/newlib_tests/tst_res_flags.c b/lib/newlib_tests/tst_res_flags.c
index cda097070..f4aaa0439 100644
--- a/lib/newlib_tests/tst_res_flags.c
+++ b/lib/newlib_tests/tst_res_flags.c
@@ -22,6 +22,7 @@ static struct tcase {
 	{FLAG(TWARN)},
 	{FLAG(TINFO)},
 	{FLAG(TDEBUG), " (printed only with -D[1,2] or LTP_DEBUG=1(y),2)"},
+	{FLAG(TDEBUG | TERRNO), " (printed only with -D[1,2] or LTP_DEBUG=1(y),2)"},
 };
 
 static void do_cleanup(void)
diff --git a/lib/tst_test.c b/lib/tst_test.c
index 5c3607016..9c5f2617f 100644
--- a/lib/tst_test.c
+++ b/lib/tst_test.c
@@ -495,7 +495,7 @@ void tst_res_(const char *file, const int lineno, int ttype,
 	 * 3. Debug output is only for test process (context->tdebug == 1).
 	 * 4. Debug output is enabled for both test and lib processes (context->tdebug == 2).
 	 */
-	if (ttype == TDEBUG) {
+	if (TTYPE_RESULT(ttype) == TDEBUG) {
 		if (!context)
 			return;
 
-- 
2.54.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] lib: tst_res(): Fix TDEBUG | TERRNO

[Andrea Cervesato via ltp]

Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] lib: tst_res(): Fix TDEBUG | TERRNO

[Jan Stancek via ltp]

On Tue, Aug 4, 2026 at 3:29 PM Cyril Hrubis <chrubis@suse.cz> wrote:
>
> Properly mask the ttype with TTYPE_MASK() when deciding if TDEBUG
> messages should be printed, otherwise any combination of TERRNO etc.
> flags is printed regardless the -D flag.
>
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>

Acked-by: Jan Stancek <jstancek@redhat.com>

> ---
>  lib/newlib_tests/tst_res_flags.c | 1 +
>  lib/tst_test.c                   | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/newlib_tests/tst_res_flags.c b/lib/newlib_tests/tst_res_flags.c
> index cda097070..f4aaa0439 100644
> --- a/lib/newlib_tests/tst_res_flags.c
> +++ b/lib/newlib_tests/tst_res_flags.c
> @@ -22,6 +22,7 @@ static struct tcase {
>         {FLAG(TWARN)},
>         {FLAG(TINFO)},
>         {FLAG(TDEBUG), " (printed only with -D[1,2] or LTP_DEBUG=1(y),2)"},
> +       {FLAG(TDEBUG | TERRNO), " (printed only with -D[1,2] or LTP_DEBUG=1(y),2)"},
>  };
>
>  static void do_cleanup(void)
> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index 5c3607016..9c5f2617f 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -495,7 +495,7 @@ void tst_res_(const char *file, const int lineno, int ttype,
>          * 3. Debug output is only for test process (context->tdebug == 1).
>          * 4. Debug output is enabled for both test and lib processes (context->tdebug == 2).
>          */
> -       if (ttype == TDEBUG) {
> +       if (TTYPE_RESULT(ttype) == TDEBUG) {
>                 if (!context)
>                         return;
>
> --
> 2.54.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] lib: tst_res(): Fix TDEBUG | TERRNO

[linuxtestproject.agent]

Hi Cyril,

On Tue, 4 Aug 2026, Cyril Hrubis wrote:
> lib: tst_res(): Fix TDEBUG | TERRNO

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] lib: tst_res(): Fix TDEBUG | TERRNO

[Li Wang]

Reviewed-by: Li Wang <li.wang@linux.dev>

-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] lib: tst_res(): Fix TDEBUG | TERRNO

[Petr Vorel]

Hi Cyril,

> Properly mask the ttype with TTYPE_MASK() when deciding if TDEBUG
> messages should be printed, otherwise any combination of TERRNO etc.
> flags is printed regardless the -D flag.

Reviewed-by: Petr Vorel <pvorel@suse.cz>
Fixes: 018f555a44 ("lib: Add support for TDEBUG tst_res() flag")

Thanks for fixing my bug!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] lib: tst_res(): Fix TDEBUG | TERRNO

[Cyril Hrubis]

Hi!
Thanks for the reviews, pushed.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp