Linux Test Project
 help / color / mirror / Atom feed
From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Cyril Hrubis" <chrubis@suse.cz>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH STAGING v2 04/16] fchroot01: test fchroot() with a directory fd
Date: Thu, 20 Aug 2026 14:23:53 +0000	[thread overview]
Message-ID: <6a870dfa.332d3c56.afc7f.5723@mx.google.com> (raw)
In-Reply-To: <aocLlPNLd_0O8VP-@yuki.lan>

Hi Cyril,

> > + * The syscall runs in a forked child so that the root of the parent
> > + * process, which the test framework needs for its cleanup, is left
> > + * untouched.
> 
> I do not think that we need this. The process that runs the run()
> function is forked from the library process in order for the test to be
> isolated from the library.
> 
> As long as we do not have a custom cleanup() function that needs to run
> outside of the jail we do not have to fork in the run().

the fork() ensures that if fchroot() passes (instead of failing) at the next
iterations we don't have a dirty environment. This is done for all tests,
so iterations always starts from scratch.

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-08-20 14:24 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20  7:44 [LTP] [PATCH v2 00/16] fchroot: add fchroot() testing suite Andrea Cervesato
2026-08-20  7:44 ` [LTP] [PATCH v2 01/16] syscalls: add v7.3 syscall numbers Andrea Cervesato
2026-08-20  8:34   ` [LTP] " linuxtestproject.agent
2026-08-20  8:37     ` Andrea Cervesato via ltp
2026-08-20  7:44 ` [LTP] [PATCH v2 02/16] syscalls: update outdated syscall entries Andrea Cervesato
2026-08-20  7:44 ` [LTP] [PATCH STAGING v2 03/16] lapi: fallback fchroot() parameters Andrea Cervesato
2026-08-20  7:44 ` [LTP] [PATCH STAGING v2 04/16] fchroot01: test fchroot() with a directory fd Andrea Cervesato
2026-08-20 14:13   ` Cyril Hrubis
2026-08-20 14:23     ` Andrea Cervesato via ltp [this message]
2026-08-20 14:58       ` Cyril Hrubis
2026-08-20  7:44 ` [LTP] [PATCH STAGING v2 05/16] fchroot02: test fchroot() invalid arguments Andrea Cervesato
2026-08-20 14:10   ` Cyril Hrubis
2026-08-20  7:44 ` [LTP] [PATCH STAGING v2 06/16] fchroot03: test fchroot() permission checks Andrea Cervesato
2026-08-20 14:19   ` Cyril Hrubis
2026-08-20  7:44 ` [LTP] [PATCH STAGING v2 07/16] fchroot04: test fchroot() into failfs as root Andrea Cervesato
2026-08-20 14:24   ` Cyril Hrubis
2026-08-20  7:44 ` [LTP] [PATCH STAGING v2 08/16] fchroot05: test failfs root can not be referenced Andrea Cervesato
2026-08-20 14:37   ` Cyril Hrubis
2026-08-20  7:44 ` [LTP] [PATCH STAGING v2 09/16] fchroot06: test path walks under failfs root Andrea Cervesato
2026-08-20 15:54   ` Cyril Hrubis
2026-08-20  7:44 ` [LTP] [PATCH STAGING v2 10/16] fchroot07: test execve blocked by " Andrea Cervesato
2026-08-20 16:17   ` Cyril Hrubis
2026-08-20  7:44 ` [LTP] [PATCH STAGING v2 11/16] fchroot08: test failfs root fork inheritance Andrea Cervesato
2026-08-20  7:44 ` [LTP] [PATCH STAGING v2 12/16] fchroot09: test setns escape from failfs root Andrea Cervesato
2026-08-20  7:44 ` [LTP] [PATCH STAGING v2 13/16] fchroot10: test failfs entry without no_new_privs Andrea Cervesato
2026-08-20  7:44 ` [LTP] [PATCH STAGING v2 14/16] fchroot11: test failfs entry with no_new_privs Andrea Cervesato
2026-08-20  7:44 ` [LTP] [PATCH STAGING v2 15/16] fchroot12: test failfs entry with shared fs_struct Andrea Cervesato
2026-08-20  7:44 ` [LTP] [PATCH STAGING v2 16/16] fchroot13: test failfs entry when chrooted Andrea Cervesato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a870dfa.332d3c56.afc7f.5723@mx.google.com \
    --to=ltp@lists.linux.it \
    --cc=andrea.cervesato@suse.com \
    --cc=chrubis@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox