From: Richard Palethorpe <rpalethorpe@suse.de>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Yan Vugenfirer <yan@daynix.com>,
ltp@lists.linux.it,
Yuri Benditovich <yuri.benditovich@daynix.com>
Subject: Re: [LTP] [PATCH v3] tst_test.sh: Normalize the locale
Date: Mon, 07 Nov 2022 10:27:23 +0000 [thread overview]
Message-ID: <87cz9zxd98.fsf@suse.de> (raw)
In-Reply-To: <Y1KdjE6gu/ILnEO6@yuki>
Hello,
Cyril Hrubis <chrubis@suse.cz> writes:
> Hi!
>> Yep. I thought more about pure C API programs. Mostly they don't have any locale
>> related code, but sometimes they call other programs via shell (e.g.
>> tst_system(), but there are more).
>>
>> I also aimed for consistency between C and shell API.
>> That's why I thought we should consider setlocale() on LC_ALL and LANG in
>> lib/tst_test.c. But maybe I'm wrong.
>
> I do not think that we need to call setlocale() in tst_test.c we do not
> have any support for locales there anyways.
>
> As for any programs executed from these as long as environment is
> propagated correctly the locale would be set to C once the corresponding
> program calls setlocale() in main().
>
> --
> Cyril Hrubis
> chrubis@suse.cz
Well I see no argument against setting the locale to C. So I have merged
it.
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-11-07 10:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 13:37 [LTP] [PATCH v3] tst_test.sh: Normalize the locale Akihiko Odaki
2022-10-20 17:30 ` Petr Vorel
2022-10-20 19:09 ` Akihiko Odaki
2022-10-21 9:11 ` Cyril Hrubis
2022-10-21 11:26 ` Petr Vorel
2022-10-21 12:42 ` Cyril Hrubis
2022-10-21 13:11 ` Petr Vorel
2022-10-21 13:24 ` Cyril Hrubis
2022-11-07 10:27 ` Richard Palethorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz9zxd98.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox