public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Yan Vugenfirer <yan@daynix.com>,
	Yuri Benditovich <yuri.benditovich@daynix.com>,
	ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] tst_test.sh: Normalize the locale
Date: Fri, 21 Oct 2022 13:26:05 +0200	[thread overview]
Message-ID: <Y1KBzfdqbibHmAa3@pevik> (raw)
In-Reply-To: <Y1JiQSWlxVSkhuoq@yuki>

Hi Cyril,

> Hi!
> > > diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
> > > index 28b7d12ba..5ebbe1d25 100644
> > > --- a/testcases/lib/tst_test.sh
> > > +++ b/testcases/lib/tst_test.sh
> > > @@ -831,3 +831,5 @@ if [ -z "$TST_NO_DEFAULT_RUN" ]; then
> > >  		fi
> > >  	fi
> > >  fi
> > > +
> > > +export LC_ALL=C

> > Thinking about it twice this might have impact on other tests.
> > Li, Cyril, any idea about it?

> Actually I think that we should have put this into the tst_test.sh from
> the start. We do have this as a workaround in du01.sh and telnet01.sh
> already.

> The plus side is that all possible bugreports from users will have all
> messages in english which would make debugging easier.

Thanks for acking this.

I suppose Akihiko is correct that we don't have to put it via setlocale()
in C API, right?

Also I guess you prefer this version (LC_ALL=C). I suggested unset LC_ALL;
export LC_COLLATE=C; export LC_NUMERIC=C as it's used in kernel's Makefile (they
have more there, but IMHO only this is relevant for us).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-10-21 11:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20 13:37 [LTP] [PATCH v3] tst_test.sh: Normalize the locale Akihiko Odaki
2022-10-20 17:30 ` Petr Vorel
2022-10-20 19:09   ` Akihiko Odaki
2022-10-21  9:11   ` Cyril Hrubis
2022-10-21 11:26     ` Petr Vorel [this message]
2022-10-21 12:42       ` Cyril Hrubis
2022-10-21 13:11         ` Petr Vorel
2022-10-21 13:24           ` Cyril Hrubis
2022-11-07 10:27             ` Richard Palethorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1KBzfdqbibHmAa3@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=yan@daynix.com \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox