From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1] sched/sched_stress:Modify sched driver param to run long term testcases
Date: Wed, 6 Jan 2021 11:25:20 +0100 [thread overview]
Message-ID: <X/WQEEj8Kx+tvz78@yuki.lan> (raw)
In-Reply-To: <1602841876-91490-1-git-send-email-luofenglin1@huawei.com>
Hi!
> Add sched_driver process slots param to 10, then long term testcases can run.
> Additionally, add sched_driver run time 0.05 hour, long term testcases
> run 1/5 of total time.
This does not say why should we run the long term testcases for 1/5 of
total time. As far as I can tell the code looks like the long term tests
are supposed to run on background while we execute the short term tests
in a loop while changing their priority.
Also each logical change should be in a separate patch.
The change to to increase the slots looks good, but should really go in
as a separate patch that explains the change.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2021-01-06 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 9:51 [LTP] [PATCH v1] sched/sched_stress:Modify sched driver param to run long term testcases Luo Fenglin
2020-10-16 9:51 ` [LTP] [PATCH v2] sched/sched_stress:Fixed param of sched_tc Luo Fenglin
2021-01-06 10:29 ` Cyril Hrubis
2020-10-16 9:51 ` [LTP] [PATCH v3] sched/sched_stress:Bugfix for setting real time priority Luo Fenglin
2021-01-06 10:44 ` Cyril Hrubis
2021-01-06 10:25 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/WQEEj8Kx+tvz78@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox