From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] sched/sched_stress:Fixed param of sched_tc
Date: Wed, 6 Jan 2021 11:29:35 +0100 [thread overview]
Message-ID: <X/WRDyuFbxDnVLYS@yuki.lan> (raw)
In-Reply-To: <1602841876-91490-2-git-send-email-luofenglin1@huawei.com>
Hi!
> Rt flag of sched_tc must like "-pfixed" or "-pvariable"
>
> Signed-off-by: luofenglin <luofenglin1@huawei.com>
> ---
> .../kernel/sched/sched_stress/sched_driver.c | 51 ++++++++++---------
> 1 file changed, 27 insertions(+), 24 deletions(-)
>
> diff --git a/testcases/kernel/sched/sched_stress/sched_driver.c b/testcases/kernel/sched/sched_stress/sched_driver.c
> index 1bee9d130..475369b46 100644
> --- a/testcases/kernel/sched/sched_stress/sched_driver.c
> +++ b/testcases/kernel/sched/sched_stress/sched_driver.c
> @@ -621,25 +621,28 @@ char *execution_time; /* runtime hours to pass to each testcase */
> printf("long-term slots available: %d\n",
> long_term_slot_total);
>
> + char timeparam[30];
> + sprintf(timeparam, "-t%s", execution_time);
Why do we need this? It's not explained in the commit message at all.
The other change looks obviously fine.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-01-06 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 9:51 [LTP] [PATCH v1] sched/sched_stress:Modify sched driver param to run long term testcases Luo Fenglin
2020-10-16 9:51 ` [LTP] [PATCH v2] sched/sched_stress:Fixed param of sched_tc Luo Fenglin
2021-01-06 10:29 ` Cyril Hrubis [this message]
2020-10-16 9:51 ` [LTP] [PATCH v3] sched/sched_stress:Bugfix for setting real time priority Luo Fenglin
2021-01-06 10:44 ` Cyril Hrubis
2021-01-06 10:25 ` [LTP] [PATCH v1] sched/sched_stress:Modify sched driver param to run long term testcases Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/WRDyuFbxDnVLYS@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox