[LTP] [PATCH 1/2] build.sh: Remove deprecated CROSS_COMPILE

[LTP] [PATCH 1/2] build.sh: Remove deprecated CROSS_COMPILE

[Li Zhijian]

The CROSS_COMPILE was no longer used by ltp since 400ac9bbe20.

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
 build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build.sh b/build.sh
index 452cc6f4c..602ca419e 100755
--- a/build.sh
+++ b/build.sh
@@ -64,7 +64,7 @@ build_cross()
 	fi
 
 	echo "===== cross-compile ${host} ${1}-tree build into $PREFIX ====="
-	build $1 $2 "--host=$host" CROSS_COMPILE="${host}-"
+	build $1 $2 "--host=$host"
 }
 
 build()
-- 
2.30.0

[LTP] [PATCH 2/2] build.sh: support compiler with path prefix

[Li Zhijian]

Previously, specify a compiler with path prefix will lead to a error
like below:
ltp$ ./build.sh -t cross -c /opt/gcc-4.9.3-64-gnu/bin/mips64el-linux-gcc
...
It was created by ltp configure LTP_VERSION, which was
generated by GNU Autoconf 2.69.  Invocation command line was

  $ ./configure --with-open-posix-testsuite --with-realtime-testsuite --prefix=/home/lizj/ltp-install --host=/opt/gcc-4.9.3-64-gnu/bin/mips64el-linux
...
 #define VERSION "LTP_VERSION"

configure: exit 1

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
 build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build.sh b/build.sh
index 602ca419e..1ec6a51d8 100755
--- a/build.sh
+++ b/build.sh
@@ -57,7 +57,7 @@ build_native()
 
 build_cross()
 {
-	local host="${CC%-gcc}"
+	local host=$(basename "${CC%-gcc}")
 	if [ "$host" = "gcc" ]; then
 		echo "Invalid CC variable for cross compilation: $CC (clang not supported)" >&2
 		exit 1
-- 
2.30.0

[LTP] [PATCH 1/2] build.sh: Remove deprecated CROSS_COMPILE

[Xiao Yang]

Hi Li,

Thanks for your work, I pushed the patch set. :-)

Best Regards,
Xiao Yang
On 2021/1/11 11:07, Li Zhijian wrote:
> The CROSS_COMPILE was no longer used by ltp since 400ac9bbe20.
>
> Signed-off-by: Li Zhijian<lizhijian@cn.fujitsu.com>
> ---
>   build.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/build.sh b/build.sh
> index 452cc6f4c..602ca419e 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -64,7 +64,7 @@ build_cross()
>   	fi
>
>   	echo "===== cross-compile ${host} ${1}-tree build into $PREFIX ====="
> -	build $1 $2 "--host=$host" CROSS_COMPILE="${host}-"
> +	build $1 $2 "--host=$host"
>   }
>
>   build()

[LTP] [PATCH 1/2] build.sh: Remove deprecated CROSS_COMPILE

[Xiao Yang]

Hi Petr,

I have merged it because CROSS_COMPILE seems unneeded.
Please tell me if you have any objection.

Best Regards,
Xiao Yang
On 2021/1/11 11:07, Li Zhijian wrote:
> The CROSS_COMPILE was no longer used by ltp since 400ac9bbe20.
>
> Signed-off-by: Li Zhijian<lizhijian@cn.fujitsu.com>
> ---
>   build.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/build.sh b/build.sh
> index 452cc6f4c..602ca419e 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -64,7 +64,7 @@ build_cross()
>   	fi
>
>   	echo "===== cross-compile ${host} ${1}-tree build into $PREFIX ====="
> -	build $1 $2 "--host=$host" CROSS_COMPILE="${host}-"
> +	build $1 $2 "--host=$host"
>   }
>
>   build()

[LTP] [PATCH 1/2] build.sh: Remove deprecated CROSS_COMPILE

[Petr Vorel]

Hi Li,

> The CROSS_COMPILE was no longer used by ltp since 400ac9bbe20.

> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---
>  build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/build.sh b/build.sh
> index 452cc6f4c..602ca419e 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -64,7 +64,7 @@ build_cross()
>  	fi

>  	echo "===== cross-compile ${host} ${1}-tree build into $PREFIX ====="
> -	build $1 $2 "--host=$host" CROSS_COMPILE="${host}-"
I looked what would require CROSS_COMPILE support. It's somehow duplicate to
autoconf --host parameter.

Although it wouldn't be difficult to add a support into configure.ac and
include/mk/config.mk.in via AC_ARG_VAR, it's use would require:

1) either migrate everything to pkg-config (but libnuma and libaio does not
support it) and use PKG_CONFIG_LIBDIR

2) fix host cpu detection in m4/ltp-host-cpu.m4 (parse CROSS_COMPILE).

=> IMHO it's not worth of doing it, thus good we removed it.

Kind regards,
Petr

> +	build $1 $2 "--host=$host"
>  }

>  build()