* [LTP] [PATCH] fastopen: add require to sch_netem driver
@ 2020-12-17 8:58 Kory Maincent
2020-12-17 13:25 ` Petr Vorel
2020-12-18 10:58 ` Petr Vorel
0 siblings, 2 replies; 5+ messages in thread
From: Kory Maincent @ 2020-12-17 8:58 UTC (permalink / raw)
To: ltp
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
testcases/network/tcp_fastopen/tcp_fastopen_run.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/testcases/network/tcp_fastopen/tcp_fastopen_run.sh b/testcases/network/tcp_fastopen/tcp_fastopen_run.sh
index fb2cb8fc2..0e59ed506 100755
--- a/testcases/network/tcp_fastopen/tcp_fastopen_run.sh
+++ b/testcases/network/tcp_fastopen/tcp_fastopen_run.sh
@@ -11,6 +11,7 @@ TST_MIN_KVER="3.7"
TST_NEEDS_TMPDIR=1
TST_NEEDS_ROOT=1
TST_NEEDS_CMDS="tc"
+TST_NEEDS_DRIVERS="sch_netem"
TST_OPTS="R:"
TST_USAGE=tcp_fastopen_usage
TST_PARSE_ARGS=tcp_fastopen_parse_args
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [LTP] [PATCH] fastopen: add require to sch_netem driver
2020-12-17 8:58 [LTP] [PATCH] fastopen: add require to sch_netem driver Kory Maincent
@ 2020-12-17 13:25 ` Petr Vorel
2020-12-17 14:29 ` =?unknown-8bit?q?K=C3=B6ry?= Maincent
2020-12-18 10:58 ` Petr Vorel
1 sibling, 1 reply; 5+ messages in thread
From: Petr Vorel @ 2020-12-17 13:25 UTC (permalink / raw)
To: ltp
Hi Kory,
> +TST_NEEDS_DRIVERS="sch_netem"
On my system also veth, xfrm_algo and xfrm_user are loaded.
veth is added because I use network namespaces based testing (I'll add it on
separate patch) and xfrm_algo is used xfrm_user.
Thus maybe add also xfrm_user?
TST_NEEDS_DRIVERS="sch_netem xfrm_user"
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH] fastopen: add require to sch_netem driver
2020-12-17 13:25 ` Petr Vorel
@ 2020-12-17 14:29 ` =?unknown-8bit?q?K=C3=B6ry?= Maincent
2020-12-17 15:01 ` Petr Vorel
0 siblings, 1 reply; 5+ messages in thread
From: =?unknown-8bit?q?K=C3=B6ry?= Maincent @ 2020-12-17 14:29 UTC (permalink / raw)
To: ltp
Hi Petr,
On Thu, 17 Dec 2020 14:25:59 +0100
Petr Vorel <pvorel@suse.cz> wrote:
> Hi Kory,
>
> > +TST_NEEDS_DRIVERS="sch_netem"
> On my system also veth, xfrm_algo and xfrm_user are loaded.
>
> veth is added because I use network namespaces based testing (I'll add it on
> separate patch) and xfrm_algo is used xfrm_user.
The xfrm_user driver seems not to be needed for the fastopen test.
Regards,
K?ry
>
> Thus maybe add also xfrm_user?
> TST_NEEDS_DRIVERS="sch_netem xfrm_user"
>
> Kind regards,
> Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH] fastopen: add require to sch_netem driver
2020-12-17 14:29 ` =?unknown-8bit?q?K=C3=B6ry?= Maincent
@ 2020-12-17 15:01 ` Petr Vorel
0 siblings, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2020-12-17 15:01 UTC (permalink / raw)
To: ltp
Hi Kory,
> > > +TST_NEEDS_DRIVERS="sch_netem"
> > On my system also veth, xfrm_algo and xfrm_user are loaded.
> > veth is added because I use network namespaces based testing (I'll add it on
> > separate patch) and xfrm_algo is used xfrm_user.
> The xfrm_user driver seems not to be needed for the fastopen test.
Thanks for info. Correct, it's loaded by ip xfrm in tst_init_iface()
(which is not required since 250438496).
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH] fastopen: add require to sch_netem driver
2020-12-17 8:58 [LTP] [PATCH] fastopen: add require to sch_netem driver Kory Maincent
2020-12-17 13:25 ` Petr Vorel
@ 2020-12-18 10:58 ` Petr Vorel
1 sibling, 0 replies; 5+ messages in thread
From: Petr Vorel @ 2020-12-18 10:58 UTC (permalink / raw)
To: ltp
Hi Kory,
thanks, merged!
Kind regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-18 10:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-17 8:58 [LTP] [PATCH] fastopen: add require to sch_netem driver Kory Maincent
2020-12-17 13:25 ` Petr Vorel
2020-12-17 14:29 ` =?unknown-8bit?q?K=C3=B6ry?= Maincent
2020-12-17 15:01 ` Petr Vorel
2020-12-18 10:58 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox