From: Petr Vorel <pvorel@suse.cz>
To: Akihiko Odaki <akihiko.odaki@daynix.com>,
ltp@lists.linux.it, Yan Vugenfirer <yan@daynix.com>,
Yuri Benditovich <yuri.benditovich@daynix.com>
Subject: Re: [LTP] [PATCH 1/6] ftp/ftp01: Use tst_net.sh
Date: Mon, 24 Oct 2022 12:18:59 +0200 [thread overview]
Message-ID: <Y1Zmk9kheWANsZ9Z@pevik> (raw)
In-Reply-To: <Y1Ze470vch74uGNg@pevik>
Hi Akihiko,
...
> > I just modified this test because it is annoying to set up rsh just to fix
> > this test so I would rather not put more effort for further improvement.
> Understand, ack. Thanks for your work!
> > Personally I don't object to remove this test either.
> The fastest solution is to merge your fixed version.
> But there should be even more modifications:
> RHOST is obsolete, instead $(tst_ipaddr rhost) should be used.
> Therefore we should decide if this smoke test (and other FTP tests in LTP) is
> worth effort. If yes, I should force myself to create ftp_lib.sh and migrate
> everything to work similar way as ftp-upload-stress.sh.
Merged as it's some improvement. I'm not sure if I invest time to FTP in the
future, maybe we should really delete it.
The only significant change I did was to force running over SSH:
with RHOST="${RHOST:-localhost}"
In my case only first half of the tests is working (suppose just wrong setup),
but on netns everything si broken and you also tested it on SSH I dared to do
this change. I documented the proper fix above in case anybody cares.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-10-24 10:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 12:07 [LTP] [PATCH 1/6] ftp/ftp01: Use tst_net.sh Akihiko Odaki
2022-10-20 12:07 ` [LTP] [PATCH 2/6] ftp/ftp01: Remove verbose comments Akihiko Odaki
2022-10-20 12:07 ` [LTP] [PATCH 3/6] ftp/ftp01: Remove old-style command substitution Akihiko Odaki
2022-10-20 12:07 ` [LTP] [PATCH 4/6] ftp/ftp01: Remove sleep option Akihiko Odaki
2022-10-20 12:07 ` [LTP] [PATCH 5/6] ftp/ftp01: Make variables local Akihiko Odaki
2022-10-20 12:07 ` [LTP] [PATCH 6/6] ftp/ftp01: Split the test function Akihiko Odaki
2022-10-20 18:40 ` [LTP] [PATCH 1/6] ftp/ftp01: Use tst_net.sh Petr Vorel
2022-10-21 6:22 ` Petr Vorel
2022-10-22 2:49 ` Akihiko Odaki
2022-10-24 9:46 ` Petr Vorel
2022-10-24 10:18 ` Petr Vorel [this message]
2022-10-26 19:22 ` Akihiko Odaki
2022-10-26 20:47 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1Zmk9kheWANsZ9Z@pevik \
--to=pvorel@suse.cz \
--cc=akihiko.odaki@daynix.com \
--cc=ltp@lists.linux.it \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox