Re: [LTP] [PATCH 1/6] ftp/ftp01: Use tst_net.sh

[Petr Vorel <pvorel@suse.cz>]

Hi Akihiko,

> Hi,

> Thanks for suggestions, improvements, and merging.

> This test assumes FTP is set up and running and that defeats the purpose of
> netns. It is certainly possible to say the FTP test functionality is covered
> with testcases/network/stress/ftp and this test can be removed, but for now,
> the fixes allows me to execute net.tcp_cmds tests without explicitly
> excluding this.

Thanks a lot for confirming that it works with my additional changes.

IMHO ftp can be tested via, that's actually done in ftp-upload-stress.sh.

Kind regards,
Petr

> Regards,
> Akihiko Odaki

> On 2022/10/24 19:18, Petr Vorel wrote:
> > Hi Akihiko,

> > ...
> > > > I just modified this test because it is annoying to set up rsh just to fix
> > > > this test so I would rather not put more effort for further improvement.
> > > Understand, ack. Thanks for your work!

> > > > Personally I don't object to remove this test either.
> > > The fastest solution is to merge your fixed version.
> > > But there should be even more modifications:
> > > RHOST is obsolete, instead $(tst_ipaddr rhost) should be used.

> > > Therefore we should decide if this smoke test (and other FTP tests in LTP) is
> > > worth effort. If yes, I should force myself to create ftp_lib.sh and migrate
> > > everything to work similar way as ftp-upload-stress.sh.

> > Merged as it's some improvement. I'm not sure if I invest time to FTP in the
> > future, maybe we should really delete it.

> > The only significant change I did was to force running over SSH:
> > with RHOST="${RHOST:-localhost}"

> > In my case only first half of the tests is working (suppose just wrong setup),
> > but on netns everything si broken and you also tested it on SSH I dared to do
> > this change. I documented the proper fix above in case anybody cares.

> > Kind regards,
> > Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp