* [LTP] [PATCH] syscalls/statx01: Fix reading 64-bit mnt_id value from mountinfo on i586
@ 2022-11-03 23:30 Vitaly Chikunov
2022-11-04 13:44 ` Cyril Hrubis
0 siblings, 1 reply; 2+ messages in thread
From: Vitaly Chikunov @ 2022-11-03 23:30 UTC (permalink / raw)
To: Cyril Hrubis, LTP List; +Cc: Dmitry V . Levin
Fix sscanf format flag for 'uint64_t mnt_id'. Reading 'uint64_t' as
'%ld' causes intermittent false positive test error:
statx01.c:82: TFAIL: statx.stx_mnt_id(23) is different from mount_id(13820440305888919575) in /proc/self/mountinfo
because that way 'mnt_id' is filled incompletely on 32-bit
architectures.
Reported-by: Dmitry V. Levin <ldv@altlinux.org>
Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
---
testcases/kernel/syscalls/statx/statx01.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/kernel/syscalls/statx/statx01.c b/testcases/kernel/syscalls/statx/statx01.c
index 24c5e9758..60b50958b 100644
--- a/testcases/kernel/syscalls/statx/statx01.c
+++ b/testcases/kernel/syscalls/statx/statx01.c
@@ -65,7 +65,7 @@ static void test_mnt_id(struct statx *buf)
file = SAFE_FOPEN("/proc/self/mountinfo", "r");
while (fgets(line, sizeof(line), file)) {
- if (sscanf(line, "%ld %*d %d:%d", &mnt_id, &line_mjr, &line_mnr) != 3)
+ if (sscanf(line, "%"SCNu64" %*d %d:%d", &mnt_id, &line_mjr, &line_mnr) != 3)
continue;
if (line_mjr == buf->stx_dev_major && line_mnr == buf->stx_dev_minor)
--
2.33.4
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [LTP] [PATCH] syscalls/statx01: Fix reading 64-bit mnt_id value from mountinfo on i586
2022-11-03 23:30 [LTP] [PATCH] syscalls/statx01: Fix reading 64-bit mnt_id value from mountinfo on i586 Vitaly Chikunov
@ 2022-11-04 13:44 ` Cyril Hrubis
0 siblings, 0 replies; 2+ messages in thread
From: Cyril Hrubis @ 2022-11-04 13:44 UTC (permalink / raw)
To: Vitaly Chikunov; +Cc: LTP List, Dmitry V . Levin
Hi!
Pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-04 13:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-03 23:30 [LTP] [PATCH] syscalls/statx01: Fix reading 64-bit mnt_id value from mountinfo on i586 Vitaly Chikunov
2022-11-04 13:44 ` Cyril Hrubis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox