Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 1/2] lib: Fix kernel module detection on BusyBox
Date: Wed, 20 Jan 2021 13:16:03 +0100	[thread overview]
Message-ID: <YAgfA5XWXweaTkB1@pevik> (raw)
In-Reply-To: <20210119160316.4776-2-pvorel@suse.cz>

Hi,

...
> +int tst_search_driver(const char *driver, const char *file)
As Joerg pointed out, this must be static.

...
> +int tst_check_driver_(const char *driver)
And this one as well.
> +{
> +	if (!tst_search_driver(driver, "modules.dep") ||
> +		!tst_search_driver(driver, "modules.builtin"))
> +		return 0;
> +
> +	return 1;
> +}
...

Kind regards,
Petr

  parent reply	other threads:[~2021-01-20 12:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 16:03 [LTP] [PATCH v3 0/2] kernel module detection (own implementation) Petr Vorel
2021-01-19 16:03 ` [LTP] [PATCH v3 1/2] lib: Fix kernel module detection on BusyBox Petr Vorel
2021-01-19 19:56   ` Sandeep Patil
2021-01-19 21:48     ` Petr Vorel
2021-01-20 12:16   ` Petr Vorel [this message]
2021-01-20 14:14   ` Cyril Hrubis
2021-01-20 15:21     ` Petr Vorel
2021-01-20 15:28       ` Cyril Hrubis
2021-01-20 19:27         ` Petr Vorel
2021-01-19 16:03 ` [LTP] [PATCH v3 2/2] zram: Fix " Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAgfA5XWXweaTkB1@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox