From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Modify the test logic of mincore.
Date: Mon, 26 Apr 2021 14:50:21 +0200 [thread overview]
Message-ID: <YIa3Dbsl7FY6IC8f@yuki> (raw)
In-Reply-To: <f73913c8-f6ca-d8ea-60c8-e4002ac16dba@uniontech.com>
Hi!
> The test was passed before the cve patch was applied, and the test
> failed after the patch was applied, and the test results were the same
> on both the x86 and mips architectures.
>
> This cve patch changes mincore() to count "mapped" pages instead of
> "cached" pages.
I've looked at at the mincore code and found what is your problem. The
initiall patch that fixed the CVE was wrong and later reverted and
replaced with a different fix:
commit 134fca9063ad4851de767d1768180e5dede9a881
Author: Jiri Kosina <jkosina@suse.cz>
Date: Tue May 14 15:41:38 2019 -0700
mm/mincore.c: make mincore() more conservative
So it's your kernel that is broken and the test is fine.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2021-04-26 12:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 10:46 [LTP] [PATCH] Modify the test logic of mincore zhanglianjie
2021-04-12 14:41 ` Cyril Hrubis
2021-04-15 7:11 ` zhanglianjie
2021-04-15 11:05 ` Cyril Hrubis
2021-04-19 6:44 ` zhanglianjie
2021-04-19 9:05 ` Cyril Hrubis
2021-04-26 12:39 ` zhanglianjie
2021-04-26 12:50 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIa3Dbsl7FY6IC8f@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox