From: zhanglianjie <zhanglianjie@uniontech.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Modify the test logic of mincore.
Date: Mon, 19 Apr 2021 14:44:21 +0800 [thread overview]
Message-ID: <e3eabee4-6616-84dc-cc8d-bc4f23228637@uniontech.com> (raw)
In-Reply-To: <YHgd/NDLJzz68uDl@yuki>
Hi!
>>> This does not make any sense, the kernel commit explicitly states that
>>> all mapped pages are reported as in core. We do call mlock() in the
>>> child, which will fault all the pages and lock them in memory. So the
>>> test should work both before and after the fix as well.
>>>
>>> The kernel commit in question weakened mincore() in a sense that it's
>>> more likely to report pages in core than it previously was. Now all that
>>> is needed is to fault the pages by reading some bytes from them to make
>>> sure they are reported as in core.
>>>
>>> If the test fails for you, something is probably broken at your end.
>>>
>>
>> Using the CVE patch on mips, the test will fail because the child
>> process mlocks all pages, but the parent process cannot obtain these
>> pages through mincore and is locked.
>
> Sounds like a kernel bug.
>
CVE list has provided repair patches, The patch I submitted this time is
to modify the logic of the test results, do you plan to incorporate it?
next prev parent reply other threads:[~2021-04-19 6:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 10:46 [LTP] [PATCH] Modify the test logic of mincore zhanglianjie
2021-04-12 14:41 ` Cyril Hrubis
2021-04-15 7:11 ` zhanglianjie
2021-04-15 11:05 ` Cyril Hrubis
2021-04-19 6:44 ` zhanglianjie [this message]
2021-04-19 9:05 ` Cyril Hrubis
2021-04-26 12:39 ` zhanglianjie
2021-04-26 12:50 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3eabee4-6616-84dc-cc8d-bc4f23228637@uniontech.com \
--to=zhanglianjie@uniontech.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox