From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 0/3] syscalls/aio: Convert libaio wrapper function to kernel syscall
Date: Mon, 3 May 2021 21:03:35 +0200 [thread overview]
Message-ID: <YJBJB/S1ThSsNvCk@pevik> (raw)
In-Reply-To: <20210429115021.24128-1-xieziyao@huawei.com>
Hi Ziyao,
> Instead of using the libaio wrapper function, the system call is changed to be invoked via syscall(2).
Generally LGTM. Major thing for me is to replace <libaio.h> with <linux/aio_abi.h>.
Do you plan to transform other tests which now still use <libaio.h>
(testcases/kernel/io/aio/ and testcases/kernel/io/ltp-aiodio/, which are BTW
problematic on mainline kernel)? I guess it'd be good to keep some test using <libaio.h>.
FYI if you don't prefer put your copyright, I'll update it with LTP copyright.
You also mix more things in single commit: using kernel API instead of libaio
API (that you mentioned) with both code and comments cleanup. But commits are
quite compact thus LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
For whole patchset.
Kind regards,
Petr
> Xie Ziyao (3):
> syscalls/io_destroy: Convert libaio wrapper function to kernel syscall
> syscalls/io_setup: Convert libaio wrapper function to kernel syscall
> syscalls/io_submit: Convert libaio wrapper function to kernel syscall
> .../kernel/syscalls/io_destroy/io_destroy01.c | 49 ++------
> .../kernel/syscalls/io_setup/io_setup01.c | 94 +++++----------
> .../kernel/syscalls/io_submit/io_submit01.c | 110 ++++++++----------
> 3 files changed, 86 insertions(+), 167 deletions(-)
next prev parent reply other threads:[~2021-05-03 19:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 11:50 [LTP] [PATCH 0/3] syscalls/aio: Convert libaio wrapper function to kernel syscall Xie Ziyao
2021-04-29 11:50 ` [LTP] [PATCH 1/3] syscalls/io_destroy: " Xie Ziyao
2021-04-29 11:50 ` [LTP] [PATCH 2/3] syscalls/io_setup: " Xie Ziyao
2021-04-29 11:50 ` [LTP] [PATCH 3/3] syscalls/io_submit: " Xie Ziyao
2021-05-04 12:09 ` Cyril Hrubis
2021-05-06 12:27 ` Xie Ziyao
2021-05-06 12:57 ` Petr Vorel
2021-05-06 13:58 ` Cyril Hrubis
2021-05-06 18:22 ` Petr Vorel
2021-05-07 8:35 ` Xie Ziyao
2021-05-03 19:03 ` Petr Vorel [this message]
2021-05-04 4:08 ` [LTP] [PATCH 0/3] syscalls/aio: " Jan Stancek
2021-05-04 5:13 ` Petr Vorel
2021-05-04 6:19 ` xieziyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJBJB/S1ThSsNvCk@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox