From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/3] syscalls/io_submit: Convert libaio wrapper function to kernel syscall
Date: Thu, 6 May 2021 15:58:56 +0200 [thread overview]
Message-ID: <YJP2IDZIEOltnTiq@yuki> (raw)
In-Reply-To: <YJPnpfByh/C5kXbr@pevik>
Hi!
> > If we should test _both_ syscall() and the library, I would prefer to split
> > libaio and native aio into two testcases in this testsuite, since <libaio.h>
> > conflicts with <linux/aio_abi.h> during actual modification.
>
> > Excuse me, is there any other good way to solve this problem?
> NOTE: if most of the test the same, with little help of #ifdef and maybe 1-2
> macros we can have single source for both variants (compiling 2 binaries).
> See setdomainname and sethostname tests (setdomainname.h).
Not sure that it's that easy here, since we cannot include libaio.h and
aio_abi.h in a single file without getting conflicts, they define
structures with the same name with possibly different layout, which
makes this very tricky.
I guess that having separate tests for different interface would
probably be easiest solution in this case.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-05-06 13:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 11:50 [LTP] [PATCH 0/3] syscalls/aio: Convert libaio wrapper function to kernel syscall Xie Ziyao
2021-04-29 11:50 ` [LTP] [PATCH 1/3] syscalls/io_destroy: " Xie Ziyao
2021-04-29 11:50 ` [LTP] [PATCH 2/3] syscalls/io_setup: " Xie Ziyao
2021-04-29 11:50 ` [LTP] [PATCH 3/3] syscalls/io_submit: " Xie Ziyao
2021-05-04 12:09 ` Cyril Hrubis
2021-05-06 12:27 ` Xie Ziyao
2021-05-06 12:57 ` Petr Vorel
2021-05-06 13:58 ` Cyril Hrubis [this message]
2021-05-06 18:22 ` Petr Vorel
2021-05-07 8:35 ` Xie Ziyao
2021-05-03 19:03 ` [LTP] [PATCH 0/3] syscalls/aio: " Petr Vorel
2021-05-04 4:08 ` Jan Stancek
2021-05-04 5:13 ` Petr Vorel
2021-05-04 6:19 ` xieziyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJP2IDZIEOltnTiq@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox