Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] sched_get_priority_max01: Add more policies
Date: Tue, 21 Dec 2021 17:06:51 +0100	[thread overview]
Message-ID: <YcH7m45TKEWaDrG3@yuki> (raw)
In-Reply-To: <20211220201814.31596-1-pvorel@suse.cz>

Hi!
> diff --git a/testcases/kernel/syscalls/sched_get_priority_max/sched_get_priority_max01.c b/testcases/kernel/syscalls/sched_get_priority_max/sched_get_priority_max01.c
> index a1c54efd0e..0d01317033 100644
> --- a/testcases/kernel/syscalls/sched_get_priority_max/sched_get_priority_max01.c
> +++ b/testcases/kernel/syscalls/sched_get_priority_max/sched_get_priority_max01.c
> @@ -13,6 +13,8 @@
>   * compare them with expected value.
>   */
>  
> +#define _GNU_SOURCE

I supposed that we need this for SCHED_DEADLINE right? What about
alternative libc implementations, does they define SCHED_DEADLINE as
well? Do we need a fallback?

>  #include <sched.h>
>  #include "lapi/syscalls.h"
>  #include "tst_test.h"
> @@ -24,9 +26,12 @@ static struct test_case {
>  	int policy;
>  	int retval;
>  } tcases[] = {
> -	{POLICY_DESC(SCHED_OTHER), 0},
> +	{POLICY_DESC(SCHED_BATCH), 0},
> +	{POLICY_DESC(SCHED_DEADLINE), 0},
>  	{POLICY_DESC(SCHED_FIFO), 99},
> -	{POLICY_DESC(SCHED_RR), 99}
> +	{POLICY_DESC(SCHED_IDLE), 0},
> +	{POLICY_DESC(SCHED_OTHER), 0},
> +	{POLICY_DESC(SCHED_RR), 99},
>  };
>  
>  static void run_test(unsigned int nr)
> -- 
> 2.34.1
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2021-12-21 16:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20 20:18 [LTP] [PATCH 1/1] sched_get_priority_max01: Add more policies Petr Vorel
2021-12-21 16:06 ` Cyril Hrubis [this message]
2022-01-24 14:21   ` Petr Vorel
2022-01-25 10:50     ` Cyril Hrubis
2022-01-25 11:20       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YcH7m45TKEWaDrG3@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox