From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] sched_get_priority_max01: Add more policies
Date: Mon, 24 Jan 2022 15:21:26 +0100 [thread overview]
Message-ID: <Ye615gN0Yv1/WskD@pevik> (raw)
In-Reply-To: <YcH7m45TKEWaDrG3@yuki>
Hi Cyril,
> Hi!
> > diff --git a/testcases/kernel/syscalls/sched_get_priority_max/sched_get_priority_max01.c b/testcases/kernel/syscalls/sched_get_priority_max/sched_get_priority_max01.c
> > index a1c54efd0e..0d01317033 100644
> > --- a/testcases/kernel/syscalls/sched_get_priority_max/sched_get_priority_max01.c
> > +++ b/testcases/kernel/syscalls/sched_get_priority_max/sched_get_priority_max01.c
> > @@ -13,6 +13,8 @@
> > * compare them with expected value.
> > */
> > +#define _GNU_SOURCE
> I supposed that we need this for SCHED_DEADLINE right? What about
> alternative libc implementations, does they define SCHED_DEADLINE as
> well? Do we need a fallback?
Sorry for the delay (I did write a reply, but probably forget to sent).
musl and glibc support all of them, but uclibc-ng doesn't have SCHED_DEADLINE.
(and SCHED_RESET_ON_FORK). I'll send v2 with SCHED_DEADLINE fallback.
I guess SCHED_RESET_ON_FORK would deserve it's own test (man sched(7):
when set, children created by fork(2) do not inherit privileged scheduling
policies).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-01-24 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 20:18 [LTP] [PATCH 1/1] sched_get_priority_max01: Add more policies Petr Vorel
2021-12-21 16:06 ` Cyril Hrubis
2022-01-24 14:21 ` Petr Vorel [this message]
2022-01-25 10:50 ` Cyril Hrubis
2022-01-25 11:20 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ye615gN0Yv1/WskD@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox