Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1 00/10] watchqueue testing suite
Date: Tue, 4 Jan 2022 12:38:52 +0100	[thread overview]
Message-ID: <YdQxzGz/JepPnmVu@yuki> (raw)
In-Reply-To: <20220104081836.22827-1-andrea.cervesato@suse.com>

Hi!
> described in https://www.kernel.org/doc/html/latest/watch_queue.html
> 
> Andrea Cervesato (10):
>   Prepare watchqueue testing suite build
>   Add wqueue01 new test
>   Add wqueue02 new test
>   Add wqueue03 new test
>   Add wqueue04 new test
>   Add wqueue05 new test
>   Add wqueue06 new test
>   Add wqueue07 new test
>   Add wqueue08 new test

Minus the issues I've pointed out this looks like a good basic tests.

What is missing are all the more interesting cases, just by looking at
the API these are at least:

- check that we can filter out events correctly
  (both for type and subtype)

- test that fills up the queue on purpose, i.e. generates events and
  does not read back until its full, you should get special event if
  WATCH_META_LOSS_NOTIFICATION is set

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      parent reply	other threads:[~2022-01-04 11:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04  8:18 [LTP] [PATCH v1 00/10] watchqueue testing suite Andrea Cervesato via ltp
2022-01-04  8:18 ` [LTP] [PATCH v1 01/10] Prepare watchqueue testing suite build Andrea Cervesato via ltp
2022-01-04 11:05   ` Cyril Hrubis
2022-01-04  8:18 ` [LTP] [PATCH v1 02/10] Add wqueue01 new test Andrea Cervesato via ltp
2022-01-04 11:22   ` Cyril Hrubis
2022-01-04  8:18 ` [LTP] [PATCH v1 03/10] Add wqueue02 " Andrea Cervesato via ltp
2022-01-04  8:18 ` [LTP] [PATCH v1 04/10] Add wqueue03 " Andrea Cervesato via ltp
2022-01-04  8:18 ` [LTP] [PATCH v1 05/10] Add wqueue04 " Andrea Cervesato via ltp
2022-01-04  8:18 ` [LTP] [PATCH v1 06/10] Add wqueue05 " Andrea Cervesato via ltp
2022-01-04  8:18 ` [LTP] [PATCH v1 07/10] Add wqueue06 " Andrea Cervesato via ltp
2022-01-04  8:18 ` [LTP] [PATCH v1 08/10] Add wqueue07 " Andrea Cervesato via ltp
2022-01-04  8:18 ` [LTP] [PATCH v1 09/10] Add wqueue08 " Andrea Cervesato via ltp
2022-01-04  8:18 ` [LTP] [PATCH v1 10/10] Define watchqueue testing suite in runtest Andrea Cervesato via ltp
2022-01-04 11:26   ` Cyril Hrubis
2022-01-04 11:38 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YdQxzGz/JepPnmVu@yuki \
    --to=chrubis@suse.cz \
    --cc=andrea.cervesato@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox