Linux Test Project
 help / color / mirror / Atom feed
* [LTP] [PATCH 1/1] ci/wiki-mirror: Don't check path
@ 2022-01-14 10:42 Petr Vorel
  2022-01-14 14:27 ` Cyril Hrubis
  0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2022-01-14 10:42 UTC (permalink / raw)
  To: ltp

Because it's checked only from latest commit,
thus wiki does not get updated when doc change is in the latest commit
of the patchset.

Reported-by: Yang Xu <xuyang2018.jy@fujitsu.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 .github/workflows/wiki-mirror.yml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/.github/workflows/wiki-mirror.yml b/.github/workflows/wiki-mirror.yml
index d138f8f226..302667255b 100644
--- a/.github/workflows/wiki-mirror.yml
+++ b/.github/workflows/wiki-mirror.yml
@@ -7,8 +7,6 @@ on:
   push:
     branches:
       - master
-    paths:
-      - 'doc/**'
 
 jobs:
   mirror:
-- 
2.34.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [LTP] [PATCH 1/1] ci/wiki-mirror: Don't check path
  2022-01-14 10:42 [LTP] [PATCH 1/1] ci/wiki-mirror: Don't check path Petr Vorel
@ 2022-01-14 14:27 ` Cyril Hrubis
  2022-01-14 18:04   ` Petr Vorel
  0 siblings, 1 reply; 3+ messages in thread
From: Cyril Hrubis @ 2022-01-14 14:27 UTC (permalink / raw)
  To: Petr Vorel; +Cc: ltp

Hi!
> Because it's checked only from latest commit,
> thus wiki does not get updated when doc change is in the latest commit
> of the patchset.

Looking at the file we will only do a commit when there is a diff, so
this only runs a few more commands in the CI in the case that there are
no changes and the end result is same.

Looks good:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [LTP] [PATCH 1/1] ci/wiki-mirror: Don't check path
  2022-01-14 14:27 ` Cyril Hrubis
@ 2022-01-14 18:04   ` Petr Vorel
  0 siblings, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2022-01-14 18:04 UTC (permalink / raw)
  To: Cyril Hrubis; +Cc: ltp

Hi all,

> Hi!
> > Because it's checked only from latest commit,
> > thus wiki does not get updated when doc change is in the latest commit
> > of the patchset.

> Looking at the file we will only do a commit when there is a diff, so
> this only runs a few more commands in the CI in the case that there are
> no changes and the end result is same.

> Looks good:

> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

Thanks. Merged, but unfortunately it didn't help.

I guess the problem is with
if: ${{ github.event.pull_request.head.repo.full_name == 'linux-test-project/ltp' }}

I need more time to investigate, thus updating wiki manually.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-14 18:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-14 10:42 [LTP] [PATCH 1/1] ci/wiki-mirror: Don't check path Petr Vorel
2022-01-14 14:27 ` Cyril Hrubis
2022-01-14 18:04   ` Petr Vorel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox