* [LTP] [v2 PATCH 1/2] aiodio: Skip tests on tmpfs
@ 2022-01-21 13:40 Petr Vorel
2022-01-21 13:40 ` [LTP] [v2 PATCH 2/2] dio_sparse: Set timeout 30 min Petr Vorel
2022-01-21 14:29 ` [LTP] [v2 PATCH 1/2] aiodio: Skip tests on tmpfs Andrea Cervesato via ltp
0 siblings, 2 replies; 7+ messages in thread
From: Petr Vorel @ 2022-01-21 13:40 UTC (permalink / raw)
To: ltp
tmpfs does not support O_DIRECT.
Used only on newly rewritten tests (old are currently using hardcoded
paths in the runtest files).
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Reviewed-by: Martin Doucha <mdoucha@suse.cz>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Changes v1->v2:
Fix commit message.
Kind regards,
Petr
testcases/kernel/io/ltp-aiodio/aiodio_append.c | 10 ++++++++--
testcases/kernel/io/ltp-aiodio/dio_append.c | 4 ++++
testcases/kernel/io/ltp-aiodio/dio_read.c | 4 ++++
testcases/kernel/io/ltp-aiodio/dio_sparse.c | 10 ++++++++--
testcases/kernel/io/ltp-aiodio/dio_truncate.c | 10 ++++++++--
5 files changed, 32 insertions(+), 6 deletions(-)
diff --git a/testcases/kernel/io/ltp-aiodio/aiodio_append.c b/testcases/kernel/io/ltp-aiodio/aiodio_append.c
index cb04b04a57..46cc74ee4e 100644
--- a/testcases/kernel/io/ltp-aiodio/aiodio_append.c
+++ b/testcases/kernel/io/ltp-aiodio/aiodio_append.c
@@ -131,8 +131,10 @@ static void setup(void)
static void cleanup(void)
{
- *run_child = 0;
- SAFE_MUNMAP(run_child, sizeof(int));
+ if (run_child) {
+ *run_child = 0;
+ SAFE_MUNMAP(run_child, sizeof(int));
+ }
}
static void run(void)
@@ -177,6 +179,10 @@ static struct tst_test test = {
{"b:", &str_numaio, "Number of async IO blocks (default 16)"},
{}
},
+ .skip_filesystems = (const char *[]) {
+ "tmpfs",
+ NULL
+ },
};
#else
TST_TEST_TCONF("test requires libaio and its development packages");
diff --git a/testcases/kernel/io/ltp-aiodio/dio_append.c b/testcases/kernel/io/ltp-aiodio/dio_append.c
index 59fd710e70..c099793f6c 100644
--- a/testcases/kernel/io/ltp-aiodio/dio_append.c
+++ b/testcases/kernel/io/ltp-aiodio/dio_append.c
@@ -93,4 +93,8 @@ static struct tst_test test = {
{"c:", &str_appends, "Number of appends (default 1000)"},
{}
},
+ .skip_filesystems = (const char *[]) {
+ "tmpfs",
+ NULL
+ },
};
diff --git a/testcases/kernel/io/ltp-aiodio/dio_read.c b/testcases/kernel/io/ltp-aiodio/dio_read.c
index 2c2ec4bce0..67a28147fd 100644
--- a/testcases/kernel/io/ltp-aiodio/dio_read.c
+++ b/testcases/kernel/io/ltp-aiodio/dio_read.c
@@ -177,4 +177,8 @@ static struct tst_test test = {
{"s:", &str_filesize, "File size (default 128M)"},
{}
},
+ .skip_filesystems = (const char *[]) {
+ "tmpfs",
+ NULL
+ },
};
diff --git a/testcases/kernel/io/ltp-aiodio/dio_sparse.c b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
index 4ee2fbab18..39fc895d65 100644
--- a/testcases/kernel/io/ltp-aiodio/dio_sparse.c
+++ b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
@@ -83,8 +83,10 @@ static void setup(void)
static void cleanup(void)
{
- *run_child = 0;
- SAFE_MUNMAP(run_child, sizeof(int));
+ if (run_child) {
+ *run_child = 0;
+ SAFE_MUNMAP(run_child, sizeof(int));
+ }
}
static void run(void)
@@ -129,4 +131,8 @@ static struct tst_test test = {
{"o:", &str_offset, "File offset (default 0)"},
{}
},
+ .skip_filesystems = (const char *[]) {
+ "tmpfs",
+ NULL
+ },
};
diff --git a/testcases/kernel/io/ltp-aiodio/dio_truncate.c b/testcases/kernel/io/ltp-aiodio/dio_truncate.c
index 4bf11c9588..1fbf83de06 100644
--- a/testcases/kernel/io/ltp-aiodio/dio_truncate.c
+++ b/testcases/kernel/io/ltp-aiodio/dio_truncate.c
@@ -107,8 +107,10 @@ static void setup(void)
static void cleanup(void)
{
- *run_child = 0;
- SAFE_MUNMAP(run_child, sizeof(int));
+ if (run_child) {
+ *run_child = 0;
+ SAFE_MUNMAP(run_child, sizeof(int));
+ }
}
static void run(void)
@@ -163,4 +165,8 @@ static struct tst_test test = {
{"c:", &str_numwrites, "Number of append & truncate (default 100)"},
{}
},
+ .skip_filesystems = (const char *[]) {
+ "tmpfs",
+ NULL
+ },
};
--
2.34.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [LTP] [v2 PATCH 2/2] dio_sparse: Set timeout 30 min
2022-01-21 13:40 [LTP] [v2 PATCH 1/2] aiodio: Skip tests on tmpfs Petr Vorel
@ 2022-01-21 13:40 ` Petr Vorel
2022-01-21 14:17 ` Andrea Cervesato via ltp
2022-01-21 15:25 ` Martin Doucha
2022-01-21 14:29 ` [LTP] [v2 PATCH 1/2] aiodio: Skip tests on tmpfs Andrea Cervesato via ltp
1 sibling, 2 replies; 7+ messages in thread
From: Petr Vorel @ 2022-01-21 13:40 UTC (permalink / raw)
To: ltp
Originally only ADSP075 failed (dio_sparse -w 518192k -s 518192k -n 1000)
but just in case increase timeout for all newly rewritten tests.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Changes v1->v2:
Prolong the timeout only for dio_sparse (Martin)
Kind regards,
Petr
testcases/kernel/io/ltp-aiodio/dio_sparse.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/testcases/kernel/io/ltp-aiodio/dio_sparse.c b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
index 39fc895d65..0039daa8d1 100644
--- a/testcases/kernel/io/ltp-aiodio/dio_sparse.c
+++ b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
@@ -135,4 +135,5 @@ static struct tst_test test = {
"tmpfs",
NULL
},
+ .timeout = 1800,
};
--
2.34.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [LTP] [v2 PATCH 2/2] dio_sparse: Set timeout 30 min
2022-01-21 13:40 ` [LTP] [v2 PATCH 2/2] dio_sparse: Set timeout 30 min Petr Vorel
@ 2022-01-21 14:17 ` Andrea Cervesato via ltp
2022-01-21 15:25 ` Martin Doucha
1 sibling, 0 replies; 7+ messages in thread
From: Andrea Cervesato via ltp @ 2022-01-21 14:17 UTC (permalink / raw)
To: Petr Vorel, ltp
[-- Attachment #1.1: Type: text/plain, Size: 845 bytes --]
Hi,
Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>
On 1/21/22 14:40, Petr Vorel wrote:
> Originally only ADSP075 failed (dio_sparse -w 518192k -s 518192k -n 1000)
> but just in case increase timeout for all newly rewritten tests.
>
> Signed-off-by: Petr Vorel<pvorel@suse.cz>
> ---
> Changes v1->v2:
> Prolong the timeout only for dio_sparse (Martin)
>
> Kind regards,
> Petr
>
> testcases/kernel/io/ltp-aiodio/dio_sparse.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/testcases/kernel/io/ltp-aiodio/dio_sparse.c b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
> index 39fc895d65..0039daa8d1 100644
> --- a/testcases/kernel/io/ltp-aiodio/dio_sparse.c
> +++ b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
> @@ -135,4 +135,5 @@ static struct tst_test test = {
> "tmpfs",
> NULL
> },
> + .timeout = 1800,
> };
[-- Attachment #1.2: Type: text/html, Size: 1356 bytes --]
[-- Attachment #2: Type: text/plain, Size: 60 bytes --]
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [v2 PATCH 1/2] aiodio: Skip tests on tmpfs
2022-01-21 13:40 [LTP] [v2 PATCH 1/2] aiodio: Skip tests on tmpfs Petr Vorel
2022-01-21 13:40 ` [LTP] [v2 PATCH 2/2] dio_sparse: Set timeout 30 min Petr Vorel
@ 2022-01-21 14:29 ` Andrea Cervesato via ltp
2022-01-21 14:31 ` Petr Vorel
1 sibling, 1 reply; 7+ messages in thread
From: Andrea Cervesato via ltp @ 2022-01-21 14:29 UTC (permalink / raw)
To: Petr Vorel, ltp
Hi,
Acked-by: Andrea Cervesato <andrea.cervesato@suse.com>
On 1/21/22 14:40, Petr Vorel wrote:
> tmpfs does not support O_DIRECT.
>
> Used only on newly rewritten tests (old are currently using hardcoded
> paths in the runtest files).
>
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
> Reviewed-by: Martin Doucha <mdoucha@suse.cz>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Changes v1->v2:
> Fix commit message.
>
> Kind regards,
> Petr
>
> testcases/kernel/io/ltp-aiodio/aiodio_append.c | 10 ++++++++--
> testcases/kernel/io/ltp-aiodio/dio_append.c | 4 ++++
> testcases/kernel/io/ltp-aiodio/dio_read.c | 4 ++++
> testcases/kernel/io/ltp-aiodio/dio_sparse.c | 10 ++++++++--
> testcases/kernel/io/ltp-aiodio/dio_truncate.c | 10 ++++++++--
> 5 files changed, 32 insertions(+), 6 deletions(-)
>
> diff --git a/testcases/kernel/io/ltp-aiodio/aiodio_append.c b/testcases/kernel/io/ltp-aiodio/aiodio_append.c
> index cb04b04a57..46cc74ee4e 100644
> --- a/testcases/kernel/io/ltp-aiodio/aiodio_append.c
> +++ b/testcases/kernel/io/ltp-aiodio/aiodio_append.c
> @@ -131,8 +131,10 @@ static void setup(void)
>
> static void cleanup(void)
> {
> - *run_child = 0;
> - SAFE_MUNMAP(run_child, sizeof(int));
> + if (run_child) {
> + *run_child = 0;
> + SAFE_MUNMAP(run_child, sizeof(int));
> + }
> }
>
> static void run(void)
> @@ -177,6 +179,10 @@ static struct tst_test test = {
> {"b:", &str_numaio, "Number of async IO blocks (default 16)"},
> {}
> },
> + .skip_filesystems = (const char *[]) {
> + "tmpfs",
> + NULL
> + },
> };
> #else
> TST_TEST_TCONF("test requires libaio and its development packages");
> diff --git a/testcases/kernel/io/ltp-aiodio/dio_append.c b/testcases/kernel/io/ltp-aiodio/dio_append.c
> index 59fd710e70..c099793f6c 100644
> --- a/testcases/kernel/io/ltp-aiodio/dio_append.c
> +++ b/testcases/kernel/io/ltp-aiodio/dio_append.c
> @@ -93,4 +93,8 @@ static struct tst_test test = {
> {"c:", &str_appends, "Number of appends (default 1000)"},
> {}
> },
> + .skip_filesystems = (const char *[]) {
> + "tmpfs",
> + NULL
> + },
> };
> diff --git a/testcases/kernel/io/ltp-aiodio/dio_read.c b/testcases/kernel/io/ltp-aiodio/dio_read.c
> index 2c2ec4bce0..67a28147fd 100644
> --- a/testcases/kernel/io/ltp-aiodio/dio_read.c
> +++ b/testcases/kernel/io/ltp-aiodio/dio_read.c
> @@ -177,4 +177,8 @@ static struct tst_test test = {
> {"s:", &str_filesize, "File size (default 128M)"},
> {}
> },
> + .skip_filesystems = (const char *[]) {
> + "tmpfs",
> + NULL
> + },
> };
> diff --git a/testcases/kernel/io/ltp-aiodio/dio_sparse.c b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
> index 4ee2fbab18..39fc895d65 100644
> --- a/testcases/kernel/io/ltp-aiodio/dio_sparse.c
> +++ b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
> @@ -83,8 +83,10 @@ static void setup(void)
>
> static void cleanup(void)
> {
> - *run_child = 0;
> - SAFE_MUNMAP(run_child, sizeof(int));
> + if (run_child) {
> + *run_child = 0;
> + SAFE_MUNMAP(run_child, sizeof(int));
> + }
> }
>
> static void run(void)
> @@ -129,4 +131,8 @@ static struct tst_test test = {
> {"o:", &str_offset, "File offset (default 0)"},
> {}
> },
> + .skip_filesystems = (const char *[]) {
> + "tmpfs",
> + NULL
> + },
> };
> diff --git a/testcases/kernel/io/ltp-aiodio/dio_truncate.c b/testcases/kernel/io/ltp-aiodio/dio_truncate.c
> index 4bf11c9588..1fbf83de06 100644
> --- a/testcases/kernel/io/ltp-aiodio/dio_truncate.c
> +++ b/testcases/kernel/io/ltp-aiodio/dio_truncate.c
> @@ -107,8 +107,10 @@ static void setup(void)
>
> static void cleanup(void)
> {
> - *run_child = 0;
> - SAFE_MUNMAP(run_child, sizeof(int));
> + if (run_child) {
> + *run_child = 0;
> + SAFE_MUNMAP(run_child, sizeof(int));
> + }
> }
>
> static void run(void)
> @@ -163,4 +165,8 @@ static struct tst_test test = {
> {"c:", &str_numwrites, "Number of append & truncate (default 100)"},
> {}
> },
> + .skip_filesystems = (const char *[]) {
> + "tmpfs",
> + NULL
> + },
> };
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [v2 PATCH 1/2] aiodio: Skip tests on tmpfs
2022-01-21 14:29 ` [LTP] [v2 PATCH 1/2] aiodio: Skip tests on tmpfs Andrea Cervesato via ltp
@ 2022-01-21 14:31 ` Petr Vorel
0 siblings, 0 replies; 7+ messages in thread
From: Petr Vorel @ 2022-01-21 14:31 UTC (permalink / raw)
To: Andrea Cervesato; +Cc: ltp
Hi all,
thanks a lot for review, *this* patch merged.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [v2 PATCH 2/2] dio_sparse: Set timeout 30 min
2022-01-21 13:40 ` [LTP] [v2 PATCH 2/2] dio_sparse: Set timeout 30 min Petr Vorel
2022-01-21 14:17 ` Andrea Cervesato via ltp
@ 2022-01-21 15:25 ` Martin Doucha
2022-01-21 15:30 ` Petr Vorel
1 sibling, 1 reply; 7+ messages in thread
From: Martin Doucha @ 2022-01-21 15:25 UTC (permalink / raw)
To: Petr Vorel, ltp
Hi,
the commit message needs an update due to changes but otherwise:
Acked-by: Martin Doucha <mdoucha@suse.cz>
On 21. 01. 22 14:40, Petr Vorel wrote:
> Originally only ADSP075 failed (dio_sparse -w 518192k -s 518192k -n 1000)
> but just in case increase timeout for all newly rewritten tests.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Changes v1->v2:
> Prolong the timeout only for dio_sparse (Martin)
>
> Kind regards,
> Petr
>
> testcases/kernel/io/ltp-aiodio/dio_sparse.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/testcases/kernel/io/ltp-aiodio/dio_sparse.c b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
> index 39fc895d65..0039daa8d1 100644
> --- a/testcases/kernel/io/ltp-aiodio/dio_sparse.c
> +++ b/testcases/kernel/io/ltp-aiodio/dio_sparse.c
> @@ -135,4 +135,5 @@ static struct tst_test test = {
> "tmpfs",
> NULL
> },
> + .timeout = 1800,
> };
--
Martin Doucha mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [v2 PATCH 2/2] dio_sparse: Set timeout 30 min
2022-01-21 15:25 ` Martin Doucha
@ 2022-01-21 15:30 ` Petr Vorel
0 siblings, 0 replies; 7+ messages in thread
From: Petr Vorel @ 2022-01-21 15:30 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Hi Martin,
> Hi,
> the commit message needs an update due to changes but otherwise:
Thanks, again today!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-01-21 15:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-21 13:40 [LTP] [v2 PATCH 1/2] aiodio: Skip tests on tmpfs Petr Vorel
2022-01-21 13:40 ` [LTP] [v2 PATCH 2/2] dio_sparse: Set timeout 30 min Petr Vorel
2022-01-21 14:17 ` Andrea Cervesato via ltp
2022-01-21 15:25 ` Martin Doucha
2022-01-21 15:30 ` Petr Vorel
2022-01-21 14:29 ` [LTP] [v2 PATCH 1/2] aiodio: Skip tests on tmpfs Andrea Cervesato via ltp
2022-01-21 14:31 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox