From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [RFC PATCH 1/1] Remove syslog shell tests
Date: Mon, 25 Apr 2022 14:38:38 +0200 [thread overview]
Message-ID: <YmaWTqjKa8bUu/DX@rei> (raw)
In-Reply-To: <20220406193650.15653-1-pvorel@suse.cz>
Hi!
These tests are meant to test mostly the syslog daemon rather than the
syslog() syscall. I agree that such tests should be part of the
respective syslog implementations and should be removed from LTP.
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Also looking at man 2 syslog our coverage is lacking, so instead of
keeping the shell test alive we should rather write a few more tests for
the syslog(2) syscall.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-04-25 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 19:36 [LTP] [RFC PATCH 1/1] Remove syslog shell tests Petr Vorel
2022-04-08 2:56 ` Li Wang
2022-04-25 12:38 ` Cyril Hrubis [this message]
2022-04-27 7:56 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmaWTqjKa8bUu/DX@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox