From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/4] doc: Update library API doc
Date: Wed, 27 Apr 2022 10:04:11 +0200 [thread overview]
Message-ID: <Ymj4+x3b2GyD1NFK@pevik> (raw)
In-Reply-To: <630fbde9-45f7-3a8d-15e0-1ac94c45ece1@suse.cz>
Hi Martin,
...
> > +3.1 Shell libraries
> > +~~~~~~~~~~~~~~~~~~~
> > +
> > +Besides shell API libraries in 'testcases/lib' it's worth to put common code
> > +for particular tests into shell library. The filename should end '_lib.sh',
> > +they should load 'tst_test.sh' or 'tst_net.sh'.
> Better wording:
> Aside from shell API libraries in 'testcases/lib', it's worth putting
> common code for a group of tests into a shell library. The filename
> should end with '_lib.sh' and the library should load 'tst_test.sh' or
> 'tst_net.sh'.
+1, thank you!
I'll fix it before merge.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-04-27 8:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 14:41 [LTP] [PATCH v2 0/4] shell: Cleanup getopts usage Petr Vorel
2022-04-22 14:41 ` [LTP] [PATCH v2 1/4] shell: Use conditional expansion for library setup/cleanup Petr Vorel
2022-04-26 10:53 ` Martin Doucha
2022-04-27 8:02 ` Petr Vorel
2022-04-27 9:00 ` Petr Vorel
2022-04-22 14:41 ` [LTP] [PATCH v2 2/4] doc: Update library API doc Petr Vorel
2022-04-26 11:03 ` Martin Doucha
2022-04-27 8:04 ` Petr Vorel [this message]
2022-04-22 14:41 ` [LTP] [PATCH v2 3/4] tst_test.sh: Cleanup getopts usage Petr Vorel
2022-04-26 14:24 ` Martin Doucha
2022-04-27 8:10 ` Petr Vorel
2022-04-22 14:41 ` [LTP] [PATCH v2 4/4] doc: Update shell API examples Petr Vorel
2022-04-26 14:48 ` Martin Doucha
2022-04-25 3:35 ` [LTP] [PATCH v2 0/4] shell: Cleanup getopts usage Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ymj4+x3b2GyD1NFK@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox