Re: [LTP] [PATCH v2 1/4] shell: Use conditional expansion for library setup/cleanup

[Petr Vorel <pvorel@suse.cz>]

Hi Martin,

> Hi,
> there are a few files where the only change is in the copyright comment.
> I'll leave it up to you whether you want to keep those changes or drop
> them.
Very good point, I'll remove these changes before merging.

> I've also added a suggestion for another improvement in a separate
> patchset below.
Thx!

> I've also run new tests on this patchset and everything seems to work.
> Overall:

> Reviewed-by: Martin Doucha <mdoucha@suse.cz>

Thanks a lot for testing and review!
...
> > +++ b/testcases/network/busy_poll/busy_poll_lib.sh
> > @@ -1,10 +1,11 @@
> >  #!/bin/sh
> >  # SPDX-License-Identifier: GPL-2.0-or-later
> >  # Copyright (c) 2016-2018 Oracle and/or its affiliates. All Rights Reserved.
> > +# Copyright (c) Linux Test Project, 2016-2022

> > -TST_SETUP="setup"
> >  TST_TESTFUNC="test"
> > -TST_CLEANUP="cleanup"
> > +TST_SETUP="${TST_SETUP:-setup}"
> > +TST_CLEANUP="${TST_CLEANUP:-cleanup}"

> The setup() and cleanup() functions here should get a prefix, otherwise
> we're asking for duplicate definitions. But that can be added in a
> separate patchset.

Very good point, thx! Yes, I'll send it as a separate patch.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp