* [LTP] [PATCH] readahead01.c: turn comment into docparse and reword
@ 2022-07-19 7:39 Avinesh Kumar
2022-07-19 11:32 ` Cyril Hrubis
0 siblings, 1 reply; 2+ messages in thread
From: Avinesh Kumar @ 2022-07-19 7:39 UTC (permalink / raw)
To: ltp
Signed-off-by: Avinesh Kumar <akumar@suse.de>
---
testcases/kernel/syscalls/readahead/readahead01.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/readahead/readahead01.c b/testcases/kernel/syscalls/readahead/readahead01.c
index 4355457e9..ac762aa3e 100644
--- a/testcases/kernel/syscalls/readahead/readahead01.c
+++ b/testcases/kernel/syscalls/readahead/readahead01.c
@@ -3,8 +3,13 @@
* Copyright (C) 2012 Linux Test Project, Inc.
*/
-/*
- * errno tests for readahead() syscall
+/*\
+ * [Description]
+ *
+ * Verify that readahead() syscall fails with
+ * - EBADF when fd is not a valid file descriptor or is not open for reading.
+ * - EINVAL when fd does not refer to a file type to which readahead()
+ * can be applied.
*/
#define _GNU_SOURCE
#include <errno.h>
--
2.36.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [LTP] [PATCH] readahead01.c: turn comment into docparse and reword
2022-07-19 7:39 [LTP] [PATCH] readahead01.c: turn comment into docparse and reword Avinesh Kumar
@ 2022-07-19 11:32 ` Cyril Hrubis
0 siblings, 0 replies; 2+ messages in thread
From: Cyril Hrubis @ 2022-07-19 11:32 UTC (permalink / raw)
To: Avinesh Kumar; +Cc: ltp
Hi!
Pushed with fixes, thanks.
> diff --git a/testcases/kernel/syscalls/readahead/readahead01.c b/testcases/kernel/syscalls/readahead/readahead01.c
> index 4355457e9..ac762aa3e 100644
> --- a/testcases/kernel/syscalls/readahead/readahead01.c
> +++ b/testcases/kernel/syscalls/readahead/readahead01.c
> @@ -3,8 +3,13 @@
> * Copyright (C) 2012 Linux Test Project, Inc.
> */
>
> -/*
> - * errno tests for readahead() syscall
> +/*\
> + * [Description]
> + *
> + * Verify that readahead() syscall fails with
> + * - EBADF when fd is not a valid file descriptor or is not open for reading.
> + * - EINVAL when fd does not refer to a file type to which readahead()
> + * can be applied.
This does not render as a list unless there is empty line between the
"Verify that..." and the rest.
I've also added colon (:) after the "... with" as we usually do.
Please always check the resulting html pages to check if the end result
is rendered properly.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-19 11:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-19 7:39 [LTP] [PATCH] readahead01.c: turn comment into docparse and reword Avinesh Kumar
2022-07-19 11:32 ` Cyril Hrubis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox