From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] zram01.sh: Fix minimal size for XFS on kernel 5.19
Date: Fri, 30 Sep 2022 11:04:21 +0200 [thread overview]
Message-ID: <YzaxFda/gGg1TIBR@yuki> (raw)
In-Reply-To: <20220929192047.22125-1-pvorel@suse.cz>
Hi!
> mkfs.xfs for kernel 5.19 bumps minimum filesystems 300 MB. Due this we
> already updated minimal filesystem size for all_filesystems /
> $TST_ALL_FILESYSTEMS in 66e05c841. But zram01.sh does not use the API,
> thus update it now.
>
> Check for RAM size was added for f18c8fd3a for Btrfs on ppc64le due to
> larger page size. Hopefully this is not needed.
Looks to me like that check is there to make sure we have enough RAM to
run the system and create the filesystem at the same time.
It does check if we have more than 1G of memory, which seems sensible
if we are going to allocate ~300MB for a RAM based filesystem.
I would say that we should really do the same for xfs, i.e. rename the
check_space_for_brtfs to check_space_for_fs and pass the fs in the first
argument so that it can appear in the tst_res message.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-30 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 19:20 [LTP] [PATCH 1/1] zram01.sh: Fix minimal size for XFS on kernel 5.19 Petr Vorel
2022-09-30 9:04 ` Cyril Hrubis [this message]
2022-09-30 9:04 ` Petr Vorel
2022-09-30 9:06 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzaxFda/gGg1TIBR@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox