Re: [LTP] [PATCH 1/1] zram01.sh: Fix minimal size for XFS on kernel 5.19

[Petr Vorel <pvorel@suse.cz>]

> Hi!
> > mkfs.xfs for kernel 5.19 bumps minimum filesystems 300 MB. Due this we
> > already updated minimal filesystem size for all_filesystems /
> > $TST_ALL_FILESYSTEMS in 66e05c841. But zram01.sh does not use the API,
> > thus update it now.

> > Check for RAM size was added for f18c8fd3a for Btrfs on ppc64le due to
> > larger page size. Hopefully this is not needed.

> Looks to me like that check is there to make sure we have enough RAM to
> run the system and create the filesystem at the same time.

> It does check if we have more than 1G of memory, which seems sensible
> if we are going to allocate ~300MB for a RAM based filesystem.

> I would say that we should really do the same for xfs, i.e. rename the
> check_space_for_brtfs to check_space_for_fs and pass the fs in the first
> argument so that it can appear in the tst_res message.
BTW I even had originally this version prepared, thus this v1 is wrong due this
left over:

-                       check_space_for_btrfs || continue
+                       check_space_for_btrfs "$fs" || continue

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp