Re: [LTP] [PATCH v4] Add ioctl_ficlone04 test

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> This test verifies that ioctl() FICLONE/FICLONERANGE feature raises
> the right error according with bad file descriptors.
> 
> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> ---
> This testing suite is testing ioctl() FICLONE and FICLONERANGE
> functionalities. In particular, file clone and error codes.
> ---
> Changes in v4:
> - ioctl_ficlone04: add EPERM and EOPNOTSUP
> - Link to v3: https://lore.kernel.org/r/20240724-ioctl_ficlone-v3-1-bdf7551380ee@suse.com
> 
> Changes in v3:
> - ioctl_ficlone04: use a generic array for expected errors
> - Link to v2: https://lore.kernel.org/r/20240723-ioctl_ficlone-v2-0-33075bbc117f@suse.com
> 
> Changes in v2:
> - add fallback definitions
> - algorithm steps using '-'
> - avoid assigning -1 to file descriptors after close()
> - use SAFE_UNLINK() instead of remove()
> - enable both xfs and btrs for all tests
> - Link to v1: https://lore.kernel.org/r/20240530-ioctl_ficlone-v1-0-fa96f07d0fca@suse.com
> ---
>  testcases/kernel/syscalls/ioctl/.gitignore        |  1 +
>  testcases/kernel/syscalls/ioctl/ioctl_ficlone04.c | 52 +++++++++++++++++++++++
>  2 files changed, 53 insertions(+)
> 
> diff --git a/testcases/kernel/syscalls/ioctl/.gitignore b/testcases/kernel/syscalls/ioctl/.gitignore
> index 9f995b1ad..1f099ff95 100644
> --- a/testcases/kernel/syscalls/ioctl/.gitignore
> +++ b/testcases/kernel/syscalls/ioctl/.gitignore
> @@ -25,5 +25,6 @@
>  /ioctl_ficlone01
>  /ioctl_ficlone02
>  /ioctl_ficlone03
> +/ioctl_ficlone04
>  /ioctl_ficlonerange01
>  /ioctl_ficlonerange02
> diff --git a/testcases/kernel/syscalls/ioctl/ioctl_ficlone04.c b/testcases/kernel/syscalls/ioctl/ioctl_ficlone04.c
> new file mode 100644
> index 000000000..b7711ac30
> --- /dev/null
> +++ b/testcases/kernel/syscalls/ioctl/ioctl_ficlone04.c
> @@ -0,0 +1,52 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (C) 2024 Andrea Cervesato andrea.cervesato@suse.com
> + */
> +
> +/*\
> + * [Description]
> + *
> + * This test verifies that ioctl() FICLONE/FICLONERANGE feature raises the right
> + * error according with bad file descriptors.
> + */
> +
> +#include "tst_test.h"
> +#include "lapi/ficlone.h"
> +
> +static void test_bad_fd(struct tst_fd *fd_src, struct tst_fd *fd_dst)
> +{
> +	if (fd_src->type == TST_FD_FILE && fd_src->type == fd_dst->type) {
> +		tst_res(TCONF, "Skipping file: SUCCESS");

Maybe just a TINFO here.

Otherwise:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp