From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] Add ioctl_ficlone04 test
Date: Tue, 30 Jul 2024 09:42:45 +0200 [thread overview]
Message-ID: <ZqiZdbFW8sujW0HE@yuki> (raw)
In-Reply-To: <20240729215305.GB1299602@pevik>
Hi!
> > > +static void test_bad_fd(struct tst_fd *fd_src, struct tst_fd *fd_dst)
> > > +{
> > > + if (fd_src->type == TST_FD_FILE && fd_src->type == fd_dst->type) {
> > > + tst_res(TCONF, "Skipping file: SUCCESS");
>
> > Maybe just a TINFO here.
>
> +1
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> FYI with 2 extra errno (ENOTTY, EFAULT) it would run also on 4.4 kernel (the
> oldest still supported - SLE12-SP3) one with this result:
I'm pretty sure EFAULT there is a kernel bug, ENOTTY sounds strange too.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-07-30 7:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 13:12 [LTP] [PATCH v4] Add ioctl_ficlone04 test Andrea Cervesato
2024-07-26 15:10 ` Cyril Hrubis
2024-07-29 21:53 ` Petr Vorel
2024-07-30 7:42 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqiZdbFW8sujW0HE@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox