[LTP] [PATCH] max_map_count: Delete dead code

[LTP] [PATCH] max_map_count: Delete dead code

[Zhao Gongyi via ltp]

When we run the testcase on AARCH64, there are no TST_ARM defined.

Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
---
 testcases/kernel/mem/tunable/max_map_count.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/testcases/kernel/mem/tunable/max_map_count.c b/testcases/kernel/mem/tunable/max_map_count.c
index a4c3dbf8e..bfbd8b1c7 100644
--- a/testcases/kernel/mem/tunable/max_map_count.c
+++ b/testcases/kernel/mem/tunable/max_map_count.c
@@ -100,10 +100,6 @@ static bool filter_map(const char *line)
 			return true;
 		break;
 	case TST_ARM:
-		/* Skip it when run it in aarch64 */
-		if (tst_kernel_bits() == 64)
-			return false;
-
 		/* Older arm kernels didn't label their vdso maps */
 		if (!strncmp(line, "ffff0000-ffff1000", 17))
 			return true;
--
2.17.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] max_map_count: Delete dead code

[Li Wang]

[-- Attachment #1.1: Type: text/plain, Size: 392 bytes --]

Hi Gongyi,

On Mon, Nov 29, 2021 at 11:56 AM Zhao Gongyi via ltp <ltp@lists.linux.it>
wrote:

> When we run the testcase on AARCH64, there are no TST_ARM defined.
>

We thought there is a possible 32bit ARM binary runs on 64bit aarch64
kernel.
https://lists.linux.it/pipermail/ltp/2021-November/026038.html

Or, what's your test scenarios, did you build and test that?


-- 
Regards,
Li Wang

[-- Attachment #1.2: Type: text/html, Size: 1431 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] max_map_count: Delete dead code

[zhaogongyi via ltp]

[-- Attachment #1.1: Type: text/plain, Size: 1595 bytes --]

Hi,

In my test system, the __arm__ is not defined, elf head like:

ELF Header:
  Magic:   7f 45 4c 46 01 02 01 00 00 00 00 00 00 00 00 00
  Class:                             ELF32
  Data:                              2's complement, big endian
  Version:                           1 (current)
  OS/ABI:                            UNIX - System V
  ABI Version:                       0
  Type:                              DYN (Shared object file)
  Machine:                           AArch64
  Version:                           0x1
  Entry point address:               0x490
  Start of program headers:          52 (bytes into file)
  Start of section headers:          10012 (bytes into file)
  Flags:                             0x0
  Size of this header:               52 (bytes)
  Size of program headers:           32 (bytes)
  Number of program headers:         9
  Size of section headers:           40 (bytes)
  Number of section headers:         36
  Section header string table index: 35

But for other arm32 platform, the code may be usefull since i have not an older kernel version can run on arm64.

Thanks,
Gongyi


Hi Gongyi,

On Mon, Nov 29, 2021 at 11:56 AM Zhao Gongyi via ltp <ltp@lists.linux.it<mailto:ltp@lists.linux.it>> wrote:
When we run the testcase on AARCH64, there are no TST_ARM defined.

We thought there is a possible 32bit ARM binary runs on 64bit aarch64 kernel.
https://lists.linux.it/pipermail/ltp/2021-November/026038.html

Or, what's your test scenarios, did you build and test that?




--
Regards,
Li Wang

[-- Attachment #1.2: Type: text/html, Size: 11364 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp