Re: [LTP] [PATCH v2] doc: Add basic shell test description

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> > +    'shell_lib': (f'{ltp_repo}/blob/master/testcases/lib/%s', '%s'),
> +1. I was thinking about it previously for C helpers, then I preferred to show
> full path. I guess I'll later use 'shell_lib' prefix for these. I suppose we can
> keep lib/*.c path, but sure, we could also (later) add 'lib' and 'include'.

Well this is going to be easier to maintain if we ever decided to move
the content of the testcases/lib into a top level directory, where it
probably belongs.

> I wish extlinks module allow to pass more params than just one.

Yes.

> +++ doc/developers/api_shell_tests.rst
> @@ -87,9 +87,9 @@ Test setup and cleanup
>  ----------------------
>  
>  The test setup and cleanup functions are optional and passed via variables.
> -Similarily to the C API the setup is executed exactly once at the start of the
> +Similarly to the C API the setup is executed exactly once at the start of the
>  test and the test cleanup is executed at the test end or when test was
> -interrupted by ref:`tst_brk`.
> +interrupted by :ref:`tst_brk`.
>  
>     .. literalinclude:: ../../testcases/lib/tests/shell_loader_setup_cleanup.sh
> -   :language: shell
> +      :language: shell

Fixed and pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp