From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it, linuxtestproject.agent@gmail.com
Subject: Re: [LTP] lapi: Add pkt_cls.h fallback
Date: Thu, 16 Jul 2026 10:45:05 +0200 [thread overview]
Message-ID: <aliaEcUZ0xM3bhwk@yuki.lan> (raw)
In-Reply-To: <6a58980f.80d8f3ad.34c319.0fb8@mx.google.com>
Hi!
> > > > + * Same as NETDEV_REMOVE_QDISC() but does not fail when the qdisc is
> > > > + * missing (strict=0), so it can be used to clear a possibly absent qdisc.
> > > > + */
> > > > +#define NETDEV_MAY_REMOVE_QDISC(ifname, family, parent, handle, qd_kind) \
> > >
> > > New public macros in include/ require kernel-doc (/** */), not a plain
> > > block comment. The content is fine; it just needs the right opener:
> > >
> > > /**
> > > * NETDEV_MAY_REMOVE_QDISC - remove qdisc without failing if absent.
> > > * @ifname: network interface name
> > > * @family: address family
> > > * @parent: parent handle
> > > * @handle: qdisc handle
> > > * @qd_kind: qdisc kind string
> > > *
> > > * Same as NETDEV_REMOVE_QDISC() but passes strict=0, so it does not
> > > * fail when the qdisc is missing.
> > > */
> >
> > Looks reasonable. It may be a good idea to copy&paste this to the header
> > before applying the patch.
>
> But then we should do it for all the others as well, maybe we should have
> a follow up patch to document all macros instead.
That would work as well.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-07-16 8:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 8:38 [LTP] [PATCH v5 0/4] Reproducer for cve-2026-46331 Andrea Cervesato
2026-07-14 8:38 ` [LTP] [PATCH v5 1/4] lapi: Add pkt_cls.h fallback Andrea Cervesato
2026-07-14 10:53 ` [LTP] " linuxtestproject.agent
2026-07-16 8:30 ` Cyril Hrubis
2026-07-16 8:36 ` Andrea Cervesato via ltp
2026-07-16 8:45 ` Cyril Hrubis [this message]
2026-07-16 8:26 ` [LTP] [PATCH v5 1/4] " Cyril Hrubis
2026-07-14 8:38 ` [LTP] [PATCH v5 2/4] lapi: Add pkt_sched.h fallback Andrea Cervesato
2026-07-16 8:28 ` Cyril Hrubis
2026-07-14 8:39 ` [LTP] [PATCH v5 3/4] lapi: Add tc_pedit.h fallback Andrea Cervesato
2026-07-16 8:32 ` Cyril Hrubis
2026-07-14 8:39 ` [LTP] [PATCH v5 4/4] cve: Add act_pedit page-cache corruption test Andrea Cervesato
2026-07-16 12:52 ` [LTP] [PATCH v5 0/4] Reproducer for cve-2026-46331 Andrea Cervesato via ltp
-- strict thread matches above, loose matches on Subject: below --
2026-07-13 12:37 [LTP] [PATCH v4 1/4] lapi: Add pkt_cls.h fallback Andrea Cervesato
2026-07-13 14:13 ` [LTP] " linuxtestproject.agent
2026-07-07 13:42 [LTP] [PATCH v3 1/4] " Andrea Cervesato
2026-07-07 14:28 ` [LTP] " linuxtestproject.agent
2026-07-07 14:53 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aliaEcUZ0xM3bhwk@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox