* [LTP] [PATCH] tst_kconfig: Add CONFIG_* mappings for keyctl tests
@ 2026-09-22 12:20 Cyril Hrubis
2026-09-22 14:28 ` [LTP] " linuxtestproject.agent
0 siblings, 1 reply; 3+ messages in thread
From: Cyril Hrubis @ 2026-09-22 12:20 UTC (permalink / raw)
To: ltp
- keyctl23, keyctl29 need x509_key_parser
- keyctl30 needs pkcs8_key_parser
Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
---
lib/tst_kconfig.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/tst_kconfig.c b/lib/tst_kconfig.c
index 277ac6068..46eeb8ec0 100644
--- a/lib/tst_kconfig.c
+++ b/lib/tst_kconfig.c
@@ -165,6 +165,8 @@ static struct config_module_map {
{"CONFIG_NET_SCH_INGRESS", "sch_ingress"},
{"CONFIG_NET_CLS_MATCHALL", "cls_matchall"},
{"CONFIG_NET_ACT_PEDIT", "act_pedit"},
+ {"CONFIG_PKCS8_PRIVATE_KEY_PARSER", "pcks8_key_parser"},
+ {"CONFIG_X509_CERTIFICATE_PARSER", "x509_key_parser"},
{}
};
--
2.54.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [LTP] tst_kconfig: Add CONFIG_* mappings for keyctl tests
2026-09-22 12:20 [LTP] [PATCH] tst_kconfig: Add CONFIG_* mappings for keyctl tests Cyril Hrubis
@ 2026-09-22 14:28 ` linuxtestproject.agent
2026-09-22 15:11 ` Cyril Hrubis
0 siblings, 1 reply; 3+ messages in thread
From: linuxtestproject.agent @ 2026-09-22 14:28 UTC (permalink / raw)
To: Cyril Hrubis; +Cc: ltp
Hi Cyril,
On Tue Sep 22 14:20:59 2026 +0200, Cyril Hrubis wrote:
> tst_kconfig: Add CONFIG_* mappings for keyctl tests
> @@ -165,6 +165,8 @@ static struct config_module_map {
> {"CONFIG_NET_SCH_INGRESS", "sch_ingress"},
> {"CONFIG_NET_CLS_MATCHALL", "cls_matchall"},
> {"CONFIG_NET_ACT_PEDIT", "act_pedit"},
> + {"CONFIG_PKCS8_PRIVATE_KEY_PARSER", "pcks8_key_parser"},
Typo in module name "pcks8_key_parser"; change it to "pkcs8_key_parser".
When CONFIG_PKCS8_PRIVATE_KEY_PARSER=m, tst_check_module_driver() fails
to find the module and marks the kconfig as unset, causing tests like
keyctl30 to be incorrectly skipped with TCONF.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [LTP] tst_kconfig: Add CONFIG_* mappings for keyctl tests
2026-09-22 14:28 ` [LTP] " linuxtestproject.agent
@ 2026-09-22 15:11 ` Cyril Hrubis
0 siblings, 0 replies; 3+ messages in thread
From: Cyril Hrubis @ 2026-09-22 15:11 UTC (permalink / raw)
To: linuxtestproject.agent; +Cc: ltp
Hi!
> On Tue Sep 22 14:20:59 2026 +0200, Cyril Hrubis wrote:
> > tst_kconfig: Add CONFIG_* mappings for keyctl tests
>
> > @@ -165,6 +165,8 @@ static struct config_module_map {
> > {"CONFIG_NET_SCH_INGRESS", "sch_ingress"},
> > {"CONFIG_NET_CLS_MATCHALL", "cls_matchall"},
> > {"CONFIG_NET_ACT_PEDIT", "act_pedit"},
> > + {"CONFIG_PKCS8_PRIVATE_KEY_PARSER", "pcks8_key_parser"},
>
> Typo in module name "pcks8_key_parser"; change it to "pkcs8_key_parser".
> When CONFIG_PKCS8_PRIVATE_KEY_PARSER=m, tst_check_module_driver() fails
> to find the module and marks the kconfig as unset, causing tests like
> keyctl30 to be incorrectly skipped with TCONF.
>
> Verdict - Needs revision
Sigh, send v2.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-22 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-22 12:20 [LTP] [PATCH] tst_kconfig: Add CONFIG_* mappings for keyctl tests Cyril Hrubis
2026-09-22 14:28 ` [LTP] " linuxtestproject.agent
2026-09-22 15:11 ` Cyril Hrubis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox