* [LTP] [PATCH 0/4] keyctl: SLE12-SP5 build fix + libkeyutils cleanup
@ 2026-09-22 16:09 Petr Vorel
2026-09-22 16:09 ` [LTP] [PATCH 1/4] lapi/keyctl.h: Remove <keyutils.h> Petr Vorel
` (3 more replies)
0 siblings, 4 replies; 14+ messages in thread
From: Petr Vorel @ 2026-09-22 16:09 UTC (permalink / raw)
To: ltp
Hi,
first 2 commits are build fixes for SLE12-SP5 which should be merged
before release (we don't have this 4.12 in LTP CI).
3rd commit is simple cleanup.
And 4th commit the big libkeyutils removal can be postponed before release.
CI (to speedup):
* whole patchset
https://github.com/pevik/ltp/actions/runs/35749797392
* 1st, 2nd and 3rd commit
https://github.com/pevik/ltp/actions/runs/35749853642
* 1st and 2nd commit
https://github.com/pevik/ltp/actions/runs/35749868601
AFTER RELEASE:
And even further cleanup could be done after the release:
include/lapi/keyctl.h contains not only fallback structs and
definitions, but also functions, which should be moved into newly
created lib/tst_keyctl.c and include/tst_keyctl.h. We did not do it in
the past due libkeyutils dependency, which we did not want to have as
hard dependency (problem solved by 4th commit).
Kind regards,
Petr
Cyril Hrubis (1):
lapi/keyctl.h: Remove <keyutils.h>
Petr Vorel (3):
keyctl: Use struct keyctl_dh_params 'private' instead of 'priv'
m4/ltp-keyutils.m4: Remove struct keyctl_dh_params.priv check
Remove libkeyutils use
configure.ac | 5 ++++-
include/lapi/keyctl.h | 22 +++++++++----------
include/mk/config.mk.in | 1 -
m4/ltp-keyutils.m4 | 17 --------------
testcases/cve/Makefile | 2 --
testcases/kernel/syscalls/add_key/Makefile | 2 --
testcases/kernel/syscalls/keyctl/Makefile | 1 -
testcases/kernel/syscalls/keyctl/keyctl25.c | 2 +-
testcases/kernel/syscalls/keyctl/keyctl26.c | 2 +-
testcases/kernel/syscalls/keyctl/keyctl27.c | 2 +-
testcases/kernel/syscalls/keyctl/keyctl28.c | 2 +-
testcases/kernel/syscalls/landlock/Makefile | 2 --
.../kernel/syscalls/request_key/Makefile | 2 --
testcases/kernel/watchqueue/Makefile | 2 --
14 files changed, 18 insertions(+), 46 deletions(-)
delete mode 100644 m4/ltp-keyutils.m4
--
2.55.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 14+ messages in thread
* [LTP] [PATCH 1/4] lapi/keyctl.h: Remove <keyutils.h>
2026-09-22 16:09 [LTP] [PATCH 0/4] keyctl: SLE12-SP5 build fix + libkeyutils cleanup Petr Vorel
@ 2026-09-22 16:09 ` Petr Vorel
2026-09-22 18:40 ` [LTP] " linuxtestproject.agent
` (2 more replies)
2026-09-22 16:09 ` [LTP] [PATCH 2/4] keyctl: Use struct keyctl_dh_params 'private' instead of 'priv' Petr Vorel
` (2 subsequent siblings)
3 siblings, 3 replies; 14+ messages in thread
From: Petr Vorel @ 2026-09-22 16:09 UTC (permalink / raw)
To: ltp
From: Cyril Hrubis <chrubis@suse.cz>
Use only <linux/keyctl.h>. UAPI is stable enough now
+ LTP has struct and functions fallbacks. This simplifies detection.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Tested-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
[ pvorel: commit message ]
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
include/lapi/keyctl.h | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/include/lapi/keyctl.h b/include/lapi/keyctl.h
index fdb68d1725..92aea858dc 100644
--- a/include/lapi/keyctl.h
+++ b/include/lapi/keyctl.h
@@ -8,17 +8,14 @@
#include "config.h"
-#include <stdint.h>
+#ifdef HAVE_LINUX_KEYCTL_H
+# include <linux/keyctl.h>
+#endif /* HAVE_LINUX_KEYCTL_H */
-#if defined(HAVE_KEYUTILS_H) && defined(HAVE_LIBKEYUTILS)
-# include <keyutils.h>
-#else
-# ifdef HAVE_LINUX_KEYCTL_H
-# include <linux/keyctl.h>
-# endif /* HAVE_LINUX_KEYCTL_H */
+#include <stdarg.h>
+#include <stdint.h>
+#include "lapi/syscalls.h"
-# include <stdarg.h>
-# include "lapi/syscalls.h"
typedef int32_t key_serial_t;
static inline key_serial_t add_key(const char *type,
@@ -59,8 +56,6 @@ static inline key_serial_t keyctl_join_session_keyring(const char *name) {
return keyctl(KEYCTL_JOIN_SESSION_KEYRING, name);
}
-#endif /* defined(HAVE_KEYUTILS_H) && defined(HAVE_LIBKEYUTILS) */
-
#ifndef HAVE_STRUCT_KEYCTL_DH_PARAMS
struct keyctl_dh_params {
int32_t priv;
--
2.55.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [LTP] [PATCH 2/4] keyctl: Use struct keyctl_dh_params 'private' instead of 'priv'
2026-09-22 16:09 [LTP] [PATCH 0/4] keyctl: SLE12-SP5 build fix + libkeyutils cleanup Petr Vorel
2026-09-22 16:09 ` [LTP] [PATCH 1/4] lapi/keyctl.h: Remove <keyutils.h> Petr Vorel
@ 2026-09-22 16:09 ` Petr Vorel
2026-09-23 9:26 ` Li Wang
2026-09-23 10:28 ` Cyril Hrubis
2026-09-22 16:09 ` [LTP] [PATCH 3/4] m4/ltp-keyutils.m4: Remove struct keyctl_dh_params.priv check Petr Vorel
2026-09-22 16:09 ` [LTP] [PATCH 4/4] Remove libkeyutils use Petr Vorel
3 siblings, 2 replies; 14+ messages in thread
From: Petr Vorel @ 2026-09-22 16:09 UTC (permalink / raw)
To: ltp
Move struct keyctl_dh_params 'priv' member to union, together with newly
added 'private' member. This is similar what UAPI does since kernel 4.20
commit 2ecefa0a15fd0 ("keys: Fix the use of the C++ keyword "private"
in uapi/linux/keyctl.h"), which adds private member in union in struct
keyctl_dh_params in <linux/keyctl.h>:
struct keyctl_dh_params {
union {
#ifndef __cplusplus
__s32 private;
#endif
__s32 priv;
};
__s32 prime;
__s32 base;
};
This allows to unconditionally use 'private' member in keyctl tests
which fixes compilation on old kernel < 4.20:
keyctl25.c:25:11: error: ‘struct keyctl_dh_params’ has no member named ‘priv’
Fixes: ee02118e9f ("lapi/keyctl.h: Add fallback definitions for extended ops")
Suggested-by: Cyril Hrubis <chrubis@suse.cz>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
include/lapi/keyctl.h | 5 ++++-
testcases/kernel/syscalls/keyctl/keyctl25.c | 2 +-
testcases/kernel/syscalls/keyctl/keyctl26.c | 2 +-
testcases/kernel/syscalls/keyctl/keyctl27.c | 2 +-
testcases/kernel/syscalls/keyctl/keyctl28.c | 2 +-
5 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/include/lapi/keyctl.h b/include/lapi/keyctl.h
index 92aea858dc..eb4d25c42d 100644
--- a/include/lapi/keyctl.h
+++ b/include/lapi/keyctl.h
@@ -58,7 +58,10 @@ static inline key_serial_t keyctl_join_session_keyring(const char *name) {
#ifndef HAVE_STRUCT_KEYCTL_DH_PARAMS
struct keyctl_dh_params {
- int32_t priv;
+ union {
+ int32_t priv;
+ int32_t private;
+ };
int32_t prime;
int32_t base;
};
diff --git a/testcases/kernel/syscalls/keyctl/keyctl25.c b/testcases/kernel/syscalls/keyctl/keyctl25.c
index d1aa3425d4..84e76c019a 100644
--- a/testcases/kernel/syscalls/keyctl/keyctl25.c
+++ b/testcases/kernel/syscalls/keyctl/keyctl25.c
@@ -22,7 +22,7 @@ static void setup(void)
{
SAFE_KEYCTL(KEYCTL_JOIN_SESSION_KEYRING, 0, 0, 0, 0);
- dh_params->priv = SAFE_NEW_USER_KEY("dh_priv", dh_priv, sizeof(dh_priv),
+ dh_params->private = SAFE_NEW_USER_KEY("dh_priv", dh_priv, sizeof(dh_priv),
KEY_SPEC_PROCESS_KEYRING);
dh_params->prime = SAFE_NEW_USER_KEY("dh_prime", dh_prime, sizeof(dh_prime),
KEY_SPEC_PROCESS_KEYRING);
diff --git a/testcases/kernel/syscalls/keyctl/keyctl26.c b/testcases/kernel/syscalls/keyctl/keyctl26.c
index bdd852fb4c..9488e736fa 100644
--- a/testcases/kernel/syscalls/keyctl/keyctl26.c
+++ b/testcases/kernel/syscalls/keyctl/keyctl26.c
@@ -21,7 +21,7 @@ static void setup(void)
{
SAFE_KEYCTL(KEYCTL_JOIN_SESSION_KEYRING, 0, 0, 0, 0);
- dh_params->priv = SAFE_NEW_USER_KEY("dh_priv", dh_priv, sizeof(dh_priv),
+ dh_params->private = SAFE_NEW_USER_KEY("dh_priv", dh_priv, sizeof(dh_priv),
KEY_SPEC_PROCESS_KEYRING);
dh_params->prime = SAFE_NEW_USER_KEY("dh_prime", dh_prime, sizeof(dh_prime),
KEY_SPEC_PROCESS_KEYRING);
diff --git a/testcases/kernel/syscalls/keyctl/keyctl27.c b/testcases/kernel/syscalls/keyctl/keyctl27.c
index 13a1538ce6..e69b520640 100644
--- a/testcases/kernel/syscalls/keyctl/keyctl27.c
+++ b/testcases/kernel/syscalls/keyctl/keyctl27.c
@@ -27,7 +27,7 @@ static void setup(void)
{
SAFE_KEYCTL(KEYCTL_JOIN_SESSION_KEYRING, 0, 0, 0, 0);
- dh_params->priv = SAFE_NEW_USER_KEY("dh_priv", dh_priv, sizeof(dh_priv),
+ dh_params->private = SAFE_NEW_USER_KEY("dh_priv", dh_priv, sizeof(dh_priv),
KEY_SPEC_PROCESS_KEYRING);
dh_params->prime = SAFE_NEW_USER_KEY("dh_prime", dh_prime, sizeof(dh_prime),
KEY_SPEC_PROCESS_KEYRING);
diff --git a/testcases/kernel/syscalls/keyctl/keyctl28.c b/testcases/kernel/syscalls/keyctl/keyctl28.c
index 4c7f6be17e..15ca3b8fef 100644
--- a/testcases/kernel/syscalls/keyctl/keyctl28.c
+++ b/testcases/kernel/syscalls/keyctl/keyctl28.c
@@ -78,7 +78,7 @@ static void setup(void)
key_base = SAFE_NEW_USER_KEY("dh_base", dh_base, sizeof(dh_base),
KEY_SPEC_PROCESS_KEYRING);
- dh_params->priv = key_priv;
+ dh_params->private = key_priv;
dh_params->prime = key_prime;
dh_params->base = key_base;
--
2.55.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [LTP] [PATCH 3/4] m4/ltp-keyutils.m4: Remove struct keyctl_dh_params.priv check
2026-09-22 16:09 [LTP] [PATCH 0/4] keyctl: SLE12-SP5 build fix + libkeyutils cleanup Petr Vorel
2026-09-22 16:09 ` [LTP] [PATCH 1/4] lapi/keyctl.h: Remove <keyutils.h> Petr Vorel
2026-09-22 16:09 ` [LTP] [PATCH 2/4] keyctl: Use struct keyctl_dh_params 'private' instead of 'priv' Petr Vorel
@ 2026-09-22 16:09 ` Petr Vorel
2026-09-23 9:52 ` Li Wang
2026-09-23 10:29 ` Cyril Hrubis
2026-09-22 16:09 ` [LTP] [PATCH 4/4] Remove libkeyutils use Petr Vorel
3 siblings, 2 replies; 14+ messages in thread
From: Petr Vorel @ 2026-09-22 16:09 UTC (permalink / raw)
To: ltp
It was supposed to be used in keyctl25.c and other tests, but not needed
any more.
Follow-up: ee02118e9f ("lapi/keyctl.h: Add fallback definitions for extended ops")
Fixes: ee02118e9f ("lapi/keyctl.h: Add fallback definitions for extended ops")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
m4/ltp-keyutils.m4 | 2 --
1 file changed, 2 deletions(-)
diff --git a/m4/ltp-keyutils.m4 b/m4/ltp-keyutils.m4
index 35bad783e5..4a6b23dbce 100644
--- a/m4/ltp-keyutils.m4
+++ b/m4/ltp-keyutils.m4
@@ -12,6 +12,4 @@ AC_DEFUN([LTP_CHECK_KEYUTILS_SUPPORT], [
AC_CHECK_TYPES([struct keyctl_dh_params, struct keyctl_kdf_params,
struct keyctl_pkey_query, struct keyctl_pkey_params],,,
[#include <linux/keyctl.h>])
-
- AC_CHECK_MEMBERS([struct keyctl_dh_params.priv],,,[#include <linux/keyctl.h>])
])
--
2.55.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [LTP] [PATCH 4/4] Remove libkeyutils use
2026-09-22 16:09 [LTP] [PATCH 0/4] keyctl: SLE12-SP5 build fix + libkeyutils cleanup Petr Vorel
` (2 preceding siblings ...)
2026-09-22 16:09 ` [LTP] [PATCH 3/4] m4/ltp-keyutils.m4: Remove struct keyctl_dh_params.priv check Petr Vorel
@ 2026-09-22 16:09 ` Petr Vorel
3 siblings, 0 replies; 14+ messages in thread
From: Petr Vorel @ 2026-09-22 16:09 UTC (permalink / raw)
To: ltp
Using directly <linux/keyctl.h> is enough. Move the rest of struct
checks in to configure.ac (together with other struct checks).
Follow-up: bc8ead0f06 ("lapi/keyctl.h: Remove <keyutils.h>")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
configure.ac | 5 ++++-
include/mk/config.mk.in | 1 -
m4/ltp-keyutils.m4 | 15 ---------------
testcases/cve/Makefile | 2 --
testcases/kernel/syscalls/add_key/Makefile | 2 --
testcases/kernel/syscalls/keyctl/Makefile | 1 -
testcases/kernel/syscalls/landlock/Makefile | 2 --
testcases/kernel/syscalls/request_key/Makefile | 2 --
testcases/kernel/watchqueue/Makefile | 2 --
9 files changed, 4 insertions(+), 28 deletions(-)
delete mode 100644 m4/ltp-keyutils.m4
diff --git a/configure.ac b/configure.ac
index 18bfdb88c7..6ad2ee7fac 100644
--- a/configure.ac
+++ b/configure.ac
@@ -300,6 +300,10 @@ AC_CHECK_TYPES([struct uffdio_move],,,[#include <linux/userfaultfd.h>])
AC_CHECK_TYPES([struct uffdio_poison],,,[#include <linux/userfaultfd.h>])
AC_CHECK_TYPES([struct uffdio_writeprotect],,,[#include <linux/userfaultfd.h>])
+AC_CHECK_TYPES([struct keyctl_dh_params, struct keyctl_kdf_params,
+ struct keyctl_pkey_query, struct keyctl_pkey_params],,,
+ [#include <linux/keyctl.h>])
+
# Tools knobs
# Bash
@@ -422,7 +426,6 @@ LTP_CHECK_CLEAR_CACHE
LTP_CHECK_CRYPTO
LTP_CHECK_FORTIFY_SOURCE
LTP_CHECK_KERNEL_DEVEL
-LTP_CHECK_KEYUTILS_SUPPORT
LTP_CHECK_LIBMNL
LTP_CHECK_SELINUX
LTP_CHECK_SYNC_ADD_AND_FETCH
diff --git a/include/mk/config.mk.in b/include/mk/config.mk.in
index 4c3da304fc..d796306e3a 100644
--- a/include/mk/config.mk.in
+++ b/include/mk/config.mk.in
@@ -38,7 +38,6 @@ SELINUX_LIBS := @SELINUX_LIBS@
HAVE_RPC := @HAVE_RPC@
LIBTIRPC_CFLAGS := @LIBTIRPC_CFLAGS@
LIBTIRPC_LIBS := @LIBTIRPC_LIBS@
-KEYUTILS_LIBS := @KEYUTILS_LIBS@
HAVE_FTS_H := @HAVE_FTS_H@
LIBMNL_LIBS := @LIBMNL_LIBS@
LIBMNL_CFLAGS := @LIBMNL_CFLAGS@
diff --git a/m4/ltp-keyutils.m4 b/m4/ltp-keyutils.m4
deleted file mode 100644
index 4a6b23dbce..0000000000
--- a/m4/ltp-keyutils.m4
+++ /dev/null
@@ -1,15 +0,0 @@
-dnl SPDX-License-Identifier: GPL-2.0-or-later
-dnl Copyright (c) 2016 Fujitsu Ltd.
-dnl Copyright (c) 2017 Petr Vorel <pvorel@suse.cz>
-dnl Copyright (c) Linux Test Project, 2019-2026
-dnl Author: Xiao Yang <yangx.jy@cn.fujitsu.com>
-
-AC_DEFUN([LTP_CHECK_KEYUTILS_SUPPORT], [
- AC_CHECK_LIB([keyutils], [add_key],
- [AC_DEFINE(HAVE_LIBKEYUTILS, 1, [Define to 1 if you have libkeyutils installed.])
- AC_SUBST(KEYUTILS_LIBS, "-lkeyutils")])
-
- AC_CHECK_TYPES([struct keyctl_dh_params, struct keyctl_kdf_params,
- struct keyctl_pkey_query, struct keyctl_pkey_params],,,
- [#include <linux/keyctl.h>])
-])
diff --git a/testcases/cve/Makefile b/testcases/cve/Makefile
index b4e4178ebb..c7c160a1b1 100644
--- a/testcases/cve/Makefile
+++ b/testcases/cve/Makefile
@@ -9,8 +9,6 @@ CFLAGS += -D_GNU_SOURCE
stack_clash: CFLAGS += -fno-optimize-sibling-calls -Wno-infinite-recursion
-cve-2016-7042: LDLIBS += $(KEYUTILS_LIBS)
-
cve-2014-0196 cve-2016-7117 cve-2017-2671 cve-2017-17052 cve-2017-17053 ghostlock refluxfs: CFLAGS += -pthread
cve-2014-0196 cve-2016-7117 cve-2017-2671: LDLIBS += -lrt
diff --git a/testcases/kernel/syscalls/add_key/Makefile b/testcases/kernel/syscalls/add_key/Makefile
index 0f51e0bc2f..1273a4e9cb 100644
--- a/testcases/kernel/syscalls/add_key/Makefile
+++ b/testcases/kernel/syscalls/add_key/Makefile
@@ -5,6 +5,4 @@ top_srcdir ?= ../../../..
include $(top_srcdir)/include/mk/testcases.mk
-LDLIBS += $(KEYUTILS_LIBS)
-
include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/kernel/syscalls/keyctl/Makefile b/testcases/kernel/syscalls/keyctl/Makefile
index 180ece25a2..14d1d20a4e 100644
--- a/testcases/kernel/syscalls/keyctl/Makefile
+++ b/testcases/kernel/syscalls/keyctl/Makefile
@@ -5,7 +5,6 @@ top_srcdir ?= ../../../..
include $(top_srcdir)/include/mk/testcases.mk
-LDLIBS += $(KEYUTILS_LIBS)
keyctl02: LDLIBS += -lpthread
include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/kernel/syscalls/landlock/Makefile b/testcases/kernel/syscalls/landlock/Makefile
index 3734d10349..02a66be910 100644
--- a/testcases/kernel/syscalls/landlock/Makefile
+++ b/testcases/kernel/syscalls/landlock/Makefile
@@ -5,6 +5,4 @@ top_srcdir ?= ../../../..
include $(top_srcdir)/include/mk/testcases.mk
-landlock07: LDLIBS += $(KEYUTILS_LIBS)
-
include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/kernel/syscalls/request_key/Makefile b/testcases/kernel/syscalls/request_key/Makefile
index 58a99875e5..15e07c4ca1 100644
--- a/testcases/kernel/syscalls/request_key/Makefile
+++ b/testcases/kernel/syscalls/request_key/Makefile
@@ -6,6 +6,4 @@ top_srcdir ?= ../../../..
include $(top_srcdir)/include/mk/testcases.mk
-LDLIBS += $(KEYUTILS_LIBS)
-
include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/kernel/watchqueue/Makefile b/testcases/kernel/watchqueue/Makefile
index 896d66d429..cba769739b 100644
--- a/testcases/kernel/watchqueue/Makefile
+++ b/testcases/kernel/watchqueue/Makefile
@@ -4,5 +4,3 @@ top_srcdir ?= ../../..
include $(top_srcdir)/include/mk/testcases.mk
include $(top_srcdir)/include/mk/generic_leaf_target.mk
-
-LDLIBS += $(KEYUTILS_LIBS)
--
2.55.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [LTP] lapi/keyctl.h: Remove <keyutils.h>
2026-09-22 16:09 ` [LTP] [PATCH 1/4] lapi/keyctl.h: Remove <keyutils.h> Petr Vorel
@ 2026-09-22 18:40 ` linuxtestproject.agent
2026-09-23 5:33 ` Petr Vorel
2026-09-23 9:15 ` [LTP] [PATCH 1/4] " Li Wang
2026-09-23 10:27 ` Cyril Hrubis
2 siblings, 1 reply; 14+ messages in thread
From: linuxtestproject.agent @ 2026-09-22 18:40 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi Cyril,
On Tue Sep 22 18:09:08 2026 +0200, Cyril Hrubis wrote:
> lapi/keyctl.h: Remove <keyutils.h>
--- [PATCH 4/4] ---
> Follow-up: bc8ead0f06 ("lapi/keyctl.h: Remove <keyutils.h>")
Commit hash bc8ead0f06 does not exist in the repository. It refers to
patch 1 in this series (875e1f2966dc).
> LTP_CHECK_FORTIFY_SOURCE
> LTP_CHECK_KERNEL_DEVEL
> -LTP_CHECK_KEYUTILS_SUPPORT
> LTP_CHECK_LIBMNL
Removing LTP_CHECK_KEYUTILS_SUPPORT leaves the LIBRARIES summary in
configure.ac printing "keyutils: yes" unconditionally. Also remove
"keyutils: ${have_keyutils:-yes}" from the summary and "keyutils.h"
from AC_CHECK_HEADERS_ONCE.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [LTP] lapi/keyctl.h: Remove <keyutils.h>
2026-09-22 18:40 ` [LTP] " linuxtestproject.agent
@ 2026-09-23 5:33 ` Petr Vorel
0 siblings, 0 replies; 14+ messages in thread
From: Petr Vorel @ 2026-09-23 5:33 UTC (permalink / raw)
To: linuxtestproject.agent; +Cc: ltp
Hi all,
> Hi Cyril,
nit: I managed to confuse agent (there are more authors in the patchset,
maybe it should ask the sender :)).
> On Tue Sep 22 18:09:08 2026 +0200, Cyril Hrubis wrote:
> > lapi/keyctl.h: Remove <keyutils.h>
> --- [PATCH 4/4] ---
> > Follow-up: bc8ead0f06 ("lapi/keyctl.h: Remove <keyutils.h>")
> Commit hash bc8ead0f06 does not exist in the repository. It refers to
> patch 1 in this series (875e1f2966dc).
Obviously this is ok.
> > LTP_CHECK_FORTIFY_SOURCE
> > LTP_CHECK_KERNEL_DEVEL
> > -LTP_CHECK_KEYUTILS_SUPPORT
> > LTP_CHECK_LIBMNL
> Removing LTP_CHECK_KEYUTILS_SUPPORT leaves the LIBRARIES summary in
> configure.ac printing "keyutils: yes" unconditionally. Also remove
> "keyutils: ${have_keyutils:-yes}" from the summary and "keyutils.h"
> from AC_CHECK_HEADERS_ONCE.
Sigh. I'll send v2 of this commit. It likely will have to wait after the
release anyway.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [LTP] [PATCH 1/4] lapi/keyctl.h: Remove <keyutils.h>
2026-09-22 16:09 ` [LTP] [PATCH 1/4] lapi/keyctl.h: Remove <keyutils.h> Petr Vorel
2026-09-22 18:40 ` [LTP] " linuxtestproject.agent
@ 2026-09-23 9:15 ` Li Wang
2026-09-23 10:27 ` Cyril Hrubis
2 siblings, 0 replies; 14+ messages in thread
From: Li Wang @ 2026-09-23 9:15 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Reviewed-by: Li Wang <li.wang@linux.dev>
--
Regards,
Li Wang
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [LTP] [PATCH 2/4] keyctl: Use struct keyctl_dh_params 'private' instead of 'priv'
2026-09-22 16:09 ` [LTP] [PATCH 2/4] keyctl: Use struct keyctl_dh_params 'private' instead of 'priv' Petr Vorel
@ 2026-09-23 9:26 ` Li Wang
2026-09-23 10:28 ` Cyril Hrubis
1 sibling, 0 replies; 14+ messages in thread
From: Li Wang @ 2026-09-23 9:26 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Reviewed-by: Li Wang <li.wang@linux.dev>
--
Regards,
Li Wang
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [LTP] [PATCH 3/4] m4/ltp-keyutils.m4: Remove struct keyctl_dh_params.priv check
2026-09-22 16:09 ` [LTP] [PATCH 3/4] m4/ltp-keyutils.m4: Remove struct keyctl_dh_params.priv check Petr Vorel
@ 2026-09-23 9:52 ` Li Wang
2026-09-23 19:35 ` Petr Vorel
2026-09-23 10:29 ` Cyril Hrubis
1 sibling, 1 reply; 14+ messages in thread
From: Li Wang @ 2026-09-23 9:52 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Reviewed-by: Li Wang <li.wang@linux.dev>
--
Regards,
Li Wang
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [LTP] [PATCH 1/4] lapi/keyctl.h: Remove <keyutils.h>
2026-09-22 16:09 ` [LTP] [PATCH 1/4] lapi/keyctl.h: Remove <keyutils.h> Petr Vorel
2026-09-22 18:40 ` [LTP] " linuxtestproject.agent
2026-09-23 9:15 ` [LTP] [PATCH 1/4] " Li Wang
@ 2026-09-23 10:27 ` Cyril Hrubis
2 siblings, 0 replies; 14+ messages in thread
From: Cyril Hrubis @ 2026-09-23 10:27 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [LTP] [PATCH 2/4] keyctl: Use struct keyctl_dh_params 'private' instead of 'priv'
2026-09-22 16:09 ` [LTP] [PATCH 2/4] keyctl: Use struct keyctl_dh_params 'private' instead of 'priv' Petr Vorel
2026-09-23 9:26 ` Li Wang
@ 2026-09-23 10:28 ` Cyril Hrubis
1 sibling, 0 replies; 14+ messages in thread
From: Cyril Hrubis @ 2026-09-23 10:28 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [LTP] [PATCH 3/4] m4/ltp-keyutils.m4: Remove struct keyctl_dh_params.priv check
2026-09-22 16:09 ` [LTP] [PATCH 3/4] m4/ltp-keyutils.m4: Remove struct keyctl_dh_params.priv check Petr Vorel
2026-09-23 9:52 ` Li Wang
@ 2026-09-23 10:29 ` Cyril Hrubis
1 sibling, 0 replies; 14+ messages in thread
From: Cyril Hrubis @ 2026-09-23 10:29 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [LTP] [PATCH 3/4] m4/ltp-keyutils.m4: Remove struct keyctl_dh_params.priv check
2026-09-23 9:52 ` Li Wang
@ 2026-09-23 19:35 ` Petr Vorel
0 siblings, 0 replies; 14+ messages in thread
From: Petr Vorel @ 2026-09-23 19:35 UTC (permalink / raw)
To: ltp, Cyril Hrubis, Avinesh Kumar, Wei Gao, Martin Doucha,
Andrea Cervesato, Jan Stancek
Hi all,
FYI I merged these three patches.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2026-09-23 19:36 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-22 16:09 [LTP] [PATCH 0/4] keyctl: SLE12-SP5 build fix + libkeyutils cleanup Petr Vorel
2026-09-22 16:09 ` [LTP] [PATCH 1/4] lapi/keyctl.h: Remove <keyutils.h> Petr Vorel
2026-09-22 18:40 ` [LTP] " linuxtestproject.agent
2026-09-23 5:33 ` Petr Vorel
2026-09-23 9:15 ` [LTP] [PATCH 1/4] " Li Wang
2026-09-23 10:27 ` Cyril Hrubis
2026-09-22 16:09 ` [LTP] [PATCH 2/4] keyctl: Use struct keyctl_dh_params 'private' instead of 'priv' Petr Vorel
2026-09-23 9:26 ` Li Wang
2026-09-23 10:28 ` Cyril Hrubis
2026-09-22 16:09 ` [LTP] [PATCH 3/4] m4/ltp-keyutils.m4: Remove struct keyctl_dh_params.priv check Petr Vorel
2026-09-23 9:52 ` Li Wang
2026-09-23 19:35 ` Petr Vorel
2026-09-23 10:29 ` Cyril Hrubis
2026-09-22 16:09 ` [LTP] [PATCH 4/4] Remove libkeyutils use Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox