* [lustre-devel] [PATCH] staging: lov.ko: lov_object.c: fix sparse warning setting function to static
@ 2016-10-17 19:22 Ryan Swan
2016-10-17 19:38 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ryan Swan @ 2016-10-17 19:22 UTC (permalink / raw)
To: lustre-devel
Fixed: sparse WARNING: symbol 'lov_read_and_clear_async_rc' was not declared. Should it be static?
Signed-off-by: Ryan Swan <ryan@ryanswan.com>
---
drivers/staging/lustre/lustre/lov/lov_object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
index 82b99e0..c42eef6 100644
--- a/drivers/staging/lustre/lustre/lov/lov_object.c
+++ b/drivers/staging/lustre/lustre/lov/lov_object.c
@@ -1532,7 +1532,7 @@ struct lov_stripe_md *lov_lsm_addref(struct lov_object *lov)
return lsm;
}
-int lov_read_and_clear_async_rc(struct cl_object *clob)
+static int lov_read_and_clear_async_rc(struct cl_object *clob)
{
struct lu_object *luobj;
int rc = 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [lustre-devel] [PATCH] staging: lov.ko: lov_object.c: fix sparse warning setting function to static
2016-10-17 19:22 [lustre-devel] [PATCH] staging: lov.ko: lov_object.c: fix sparse warning setting function to static Ryan Swan
@ 2016-10-17 19:38 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-10-17 19:38 UTC (permalink / raw)
To: lustre-devel
On Mon, Oct 17, 2016 at 03:21:52PM -0400, Ryan Swan wrote:
> Fixed: sparse WARNING: symbol 'lov_read_and_clear_async_rc' was not declared. Should it be static?
I don't believe you actually test-built this change :(
>
> Signed-off-by: Ryan Swan <ryan@ryanswan.com>
> ---
> drivers/staging/lustre/lustre/lov/lov_object.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> index 82b99e0..c42eef6 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> @@ -1532,7 +1532,7 @@ struct lov_stripe_md *lov_lsm_addref(struct lov_object *lov)
> return lsm;
> }
>
> -int lov_read_and_clear_async_rc(struct cl_object *clob)
> +static int lov_read_and_clear_async_rc(struct cl_object *clob)
You are turning a symbol that is explicitly exported into a static one?
How is the compiler supposed to figure out what to do when you do that?
Again, always test-build your patches so you don't get a grumpy
maintainer telling you to test-build your patches...
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-17 19:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 19:22 [lustre-devel] [PATCH] staging: lov.ko: lov_object.c: fix sparse warning setting function to static Ryan Swan
2016-10-17 19:38 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox