* [lustre-devel] [PATCH] lustre: obdclass: fix sparse warning
@ 2015-11-01 8:42 Paul Davies C
2015-11-07 1:13 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Paul Davies C @ 2015-11-01 8:42 UTC (permalink / raw)
To: lustre-devel
Fix the following warning given by sparse:
drivers/staging/lustre/lustre/obdclass/cl_lock.c:690:5: warning: symbol 'cl_lock_mutex_try' was not declared. Should it be static?
Signed-off-by: Paul Davies C <pauldaviesc@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/cl_lock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/cl_lock.c b/drivers/staging/lustre/lustre/obdclass/cl_lock.c
index 5621beb..6f83452 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_lock.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_lock.c
@@ -687,7 +687,7 @@ EXPORT_SYMBOL(cl_lock_mutex_get);
*
* \see cl_lock_mutex_get()
*/
-int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock)
+static int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock)
{
int result;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [lustre-devel] [PATCH] lustre: obdclass: fix sparse warning
2015-11-01 8:42 [lustre-devel] [PATCH] lustre: obdclass: fix sparse warning Paul Davies C
@ 2015-11-07 1:13 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-11-07 1:13 UTC (permalink / raw)
To: lustre-devel
On Sun, Nov 01, 2015 at 02:12:29PM +0530, Paul Davies C wrote:
> Fix the following warning given by sparse:
>
> drivers/staging/lustre/lustre/obdclass/cl_lock.c:690:5: warning: symbol 'cl_lock_mutex_try' was not declared. Should it be static?
>
> Signed-off-by: Paul Davies C <pauldaviesc@gmail.com>
> ---
> drivers/staging/lustre/lustre/obdclass/cl_lock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_lock.c b/drivers/staging/lustre/lustre/obdclass/cl_lock.c
> index 5621beb..6f83452 100644
> --- a/drivers/staging/lustre/lustre/obdclass/cl_lock.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_lock.c
> @@ -687,7 +687,7 @@ EXPORT_SYMBOL(cl_lock_mutex_get);
> *
> * \see cl_lock_mutex_get()
> */
> -int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock)
> +static int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock)
> {
> int result;
>
Someone did this before you did, sorry :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-07 1:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-01 8:42 [lustre-devel] [PATCH] lustre: obdclass: fix sparse warning Paul Davies C
2015-11-07 1:13 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox