* [PATCH] bus: mhi: Add mru_default for Quectel EM1xx series modules.
@ 2022-01-28 5:24 Yonglin Tan
2022-02-07 8:40 ` Manivannan Sadhasivam
0 siblings, 1 reply; 2+ messages in thread
From: Yonglin Tan @ 2022-01-28 5:24 UTC (permalink / raw)
To: mani, hemantk, mhi; +Cc: linux-arm-msm, linux-kernel, Yonglin Tan
For default mechanism, the driver uses default MRU 3500 if mru_default
is not initialized. The Qualcomm configured the MRU size to 32768 in the
WWAN device FW. So, we align the driver setting with Qualcomm FW setting.
Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>
---
drivers/bus/mhi/pci_generic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
index b798958..9527b7d 100644
--- a/drivers/bus/mhi/pci_generic.c
+++ b/drivers/bus/mhi/pci_generic.c
@@ -327,6 +327,7 @@ static const struct mhi_pci_dev_info mhi_quectel_em1xx_info = {
.config = &modem_quectel_em1xx_config,
.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
.dma_data_width = 32,
+ .mru_default = 32768,
.sideband_wake = true,
};
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] bus: mhi: Add mru_default for Quectel EM1xx series modules.
2022-01-28 5:24 [PATCH] bus: mhi: Add mru_default for Quectel EM1xx series modules Yonglin Tan
@ 2022-02-07 8:40 ` Manivannan Sadhasivam
0 siblings, 0 replies; 2+ messages in thread
From: Manivannan Sadhasivam @ 2022-02-07 8:40 UTC (permalink / raw)
To: Yonglin Tan; +Cc: hemantk, mhi, linux-arm-msm, linux-kernel
On Fri, Jan 28, 2022 at 01:24:04PM +0800, Yonglin Tan wrote:
> For default mechanism, the driver uses default MRU 3500 if mru_default
> is not initialized. The Qualcomm configured the MRU size to 32768 in the
> WWAN device FW. So, we align the driver setting with Qualcomm FW setting.
>
> Signed-off-by: Yonglin Tan <yonglin.tan@outlook.com>
Please add the Fixes tag for commit ac4bf60bbaa0 and CC stable list.
Also the subject should be:
"bus: mhi: pci_generic: Add mru_default for Quectel EM1xx series"
With that,
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
> drivers/bus/mhi/pci_generic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index b798958..9527b7d 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -327,6 +327,7 @@ static const struct mhi_pci_dev_info mhi_quectel_em1xx_info = {
> .config = &modem_quectel_em1xx_config,
> .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
> .dma_data_width = 32,
> + .mru_default = 32768,
> .sideband_wake = true,
> };
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-07 8:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-28 5:24 [PATCH] bus: mhi: Add mru_default for Quectel EM1xx series modules Yonglin Tan
2022-02-07 8:40 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox