* [PATCH] bus: mhi: host: pci_generic: Use pcim_iomap_region() to request and map MHI BAR
@ 2024-10-04 2:33 Manivannan Sadhasivam
2024-10-04 17:50 ` Mayank Rana
2024-10-06 18:13 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2024-10-04 2:33 UTC (permalink / raw)
To: mhi; +Cc: linux-arm-msm, linux-kernel, Manivannan Sadhasivam, Loic Poulain
Use of both pcim_iomap_regions() and pcim_iomap_table() APIs are
deprecated. Hence, switch to pcim_iomap_region() API which handles both the
request and map of the MHI BAR region.
Cc: Loic Poulain <loic.poulain@linaro.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
Compile tested only.
drivers/bus/mhi/host/pci_generic.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 9938bb034c1c..07645ce2119a 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -917,12 +917,12 @@ static int mhi_pci_claim(struct mhi_controller *mhi_cntrl,
return err;
}
- err = pcim_iomap_regions(pdev, 1 << bar_num, pci_name(pdev));
- if (err) {
+ mhi_cntrl->regs = pcim_iomap_region(pdev, 1 << bar_num, pci_name(pdev));
+ if (IS_ERR(mhi_cntrl->regs)) {
+ err = PTR_ERR(mhi_cntrl->regs);
dev_err(&pdev->dev, "failed to map pci region: %d\n", err);
return err;
}
- mhi_cntrl->regs = pcim_iomap_table(pdev)[bar_num];
mhi_cntrl->reg_len = pci_resource_len(pdev, bar_num);
err = dma_set_mask_and_coherent(&pdev->dev, dma_mask);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: mhi: host: pci_generic: Use pcim_iomap_region() to request and map MHI BAR
2024-10-04 2:33 [PATCH] bus: mhi: host: pci_generic: Use pcim_iomap_region() to request and map MHI BAR Manivannan Sadhasivam
@ 2024-10-04 17:50 ` Mayank Rana
2024-10-06 18:13 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Mayank Rana @ 2024-10-04 17:50 UTC (permalink / raw)
To: Manivannan Sadhasivam, mhi; +Cc: linux-arm-msm, linux-kernel, Loic Poulain
On 10/3/2024 7:33 PM, Manivannan Sadhasivam wrote:
> Use of both pcim_iomap_regions() and pcim_iomap_table() APIs are
> deprecated. Hence, switch to pcim_iomap_region() API which handles both the
> request and map of the MHI BAR region.
>
> Cc: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>
> Compile tested only.
>
> drivers/bus/mhi/host/pci_generic.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 9938bb034c1c..07645ce2119a 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -917,12 +917,12 @@ static int mhi_pci_claim(struct mhi_controller *mhi_cntrl,
> return err;
> }
>
> - err = pcim_iomap_regions(pdev, 1 << bar_num, pci_name(pdev));
> - if (err) {
> + mhi_cntrl->regs = pcim_iomap_region(pdev, 1 << bar_num, pci_name(pdev));
> + if (IS_ERR(mhi_cntrl->regs)) {
> + err = PTR_ERR(mhi_cntrl->regs);
> dev_err(&pdev->dev, "failed to map pci region: %d\n", err);
> return err;
> }
> - mhi_cntrl->regs = pcim_iomap_table(pdev)[bar_num];
> mhi_cntrl->reg_len = pci_resource_len(pdev, bar_num);
>
> err = dma_set_mask_and_coherent(&pdev->dev, dma_mask);
Reviewed-by: Mayank Rana <quic_mrana@quicinc.com>
Regards,
Mayank
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: mhi: host: pci_generic: Use pcim_iomap_region() to request and map MHI BAR
2024-10-04 2:33 [PATCH] bus: mhi: host: pci_generic: Use pcim_iomap_region() to request and map MHI BAR Manivannan Sadhasivam
2024-10-04 17:50 ` Mayank Rana
@ 2024-10-06 18:13 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2024-10-06 18:13 UTC (permalink / raw)
To: mhi; +Cc: linux-arm-msm, linux-kernel, Loic Poulain
On Fri, Oct 04, 2024 at 08:03:51AM +0530, Manivannan Sadhasivam wrote:
> Use of both pcim_iomap_regions() and pcim_iomap_table() APIs are
> deprecated. Hence, switch to pcim_iomap_region() API which handles both the
> request and map of the MHI BAR region.
>
> Cc: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Applied to mhi-next!
- Mani
> ---
>
> Compile tested only.
>
> drivers/bus/mhi/host/pci_generic.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 9938bb034c1c..07645ce2119a 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -917,12 +917,12 @@ static int mhi_pci_claim(struct mhi_controller *mhi_cntrl,
> return err;
> }
>
> - err = pcim_iomap_regions(pdev, 1 << bar_num, pci_name(pdev));
> - if (err) {
> + mhi_cntrl->regs = pcim_iomap_region(pdev, 1 << bar_num, pci_name(pdev));
> + if (IS_ERR(mhi_cntrl->regs)) {
> + err = PTR_ERR(mhi_cntrl->regs);
> dev_err(&pdev->dev, "failed to map pci region: %d\n", err);
> return err;
> }
> - mhi_cntrl->regs = pcim_iomap_table(pdev)[bar_num];
> mhi_cntrl->reg_len = pci_resource_len(pdev, bar_num);
>
> err = dma_set_mask_and_coherent(&pdev->dev, dma_mask);
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-06 18:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-04 2:33 [PATCH] bus: mhi: host: pci_generic: Use pcim_iomap_region() to request and map MHI BAR Manivannan Sadhasivam
2024-10-04 17:50 ` Mayank Rana
2024-10-06 18:13 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox