MLMMJ Mailing List Manager
 help / color / mirror / Atom feed
* 1.2.6 released. No more queue littering ...
@ 2005-05-08 18:26 Mads Martin Joergensen
  2005-05-09  7:16 ` Mads Martin Joergensen
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Mads Martin Joergensen @ 2005-05-08 18:26 UTC (permalink / raw)
  To: mlmmj

Hey people,

So ... as usual Andrea Barisani have found a couple of bugs, which we've
fixed. This time the most annoying one was mlmmj littering files in
LISTDIR/queue/, in case of odd mails that were to be ignored. So after
you upgraded to 1.2.6 you should clean up your queue directories for old
crap--if any.

There's also a couple of nice patches from Jakob Hirsch, so now mlmmj
will tell you if you're trying to subscribe an already subscribed
address or trying to unsub without being subbed.

The ChangeLog has it as usual:

1.2.6
 o If prefix but no Subject: header is present, add one (Jakob Hirsch)
 o Add notification mail when subbed people try to sub (Jakob Hirsch)
 o Install SIGTERM handler in mlmmj-send to allow it to shut down
   gracefully
 o Also remove mails when it's a bounce from a person not subbed
 o Introduce read() wrapper (Stevens)
 o Bouncing confirmation mails of sub or unsub should be cleaned from
   the queue as well
 o Normally mails which doesn't have exactly one From: emailaddress are
   discarded but certain ISPs have bounce mails with no From: header,
   forcing us to allow bounce mails with no From: to make sure they're
   caught
 o In case of a succesful DSN parse, we werent deleting the mail, and
   thus littering the queue
 o When sending moderated mails, rename them so that they wont be
   moderated again while sending

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 1.2.6 released. No more queue littering ...
  2005-05-08 18:26 1.2.6 released. No more queue littering Mads Martin Joergensen
@ 2005-05-09  7:16 ` Mads Martin Joergensen
  2005-05-09 12:47 ` Jakob Hirsch
  2005-05-09 12:48 ` Mads Martin Joergensen
  2 siblings, 0 replies; 4+ messages in thread
From: Mads Martin Joergensen @ 2005-05-09  7:16 UTC (permalink / raw)
  To: mlmmj

* Mads Martin Joergensen <mmj@mmj.dk> [May 08. 2005 20:26]:
>  o If prefix but no Subject: header is present, add one (Jakob Hirsch)

There's a bug here. In case we meet a subject already we forget to clear
the flag. This patch should fix it, so that no 2 subjects are present:

--- do_all_the_voodo_here.c     8 May 2005 16:18:02 -0000       1.24
+++ do_all_the_voodo_here.c     9 May 2005 07:13:51 -0000
@@ -142,6 +142,7 @@
                /* Add Subject: prefix if wanted */
                if(prefix) {
                        if(strncasecmp(hdrline, "Subject:", 8) = 0) {
+                               subject_present = 1;
                                unqp = cleanquotedp(hdrline + 8);
                                if(strstr(hdrline + 8, prefix) = NULL &&
                                   strstr(unqp, prefix) = NULL) {


-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 1.2.6 released. No more queue littering ...
  2005-05-08 18:26 1.2.6 released. No more queue littering Mads Martin Joergensen
  2005-05-09  7:16 ` Mads Martin Joergensen
@ 2005-05-09 12:47 ` Jakob Hirsch
  2005-05-09 12:48 ` Mads Martin Joergensen
  2 siblings, 0 replies; 4+ messages in thread
From: Jakob Hirsch @ 2005-05-09 12:47 UTC (permalink / raw)
  To: mlmmj

Mads Martin Joergensen wrote:

>> o If prefix but no Subject: header is present, add one (Jakob Hirsch)
> There's a bug here. In case we meet a subject already we forget to clear
> the flag. This patch should fix it, so that no 2 subjects are present:

> +                               subject_present = 1;

It's there (a few lines below), but will only be done if the subject 
contains the prefix, which is obiously wrong.
sorry for that.

the extra setting of subject_present doesn't hurt, but for clarity, it's 
better to remove it:

--- do_all_the_voodo_here.c   2005-05-08 18:18:02 +0200
+++ do_all_the_voodo_here.c   2005-05-09 14:41:41 +0200
@@ -153,7 +154,6 @@
                                         myfree(subject);
                                         myfree(hdrline);
                                         myfree(unqp);
-                                       subject_present = 1;
                                         continue;
                                 }
                                 myfree(unqp);

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 1.2.6 released. No more queue littering ...
  2005-05-08 18:26 1.2.6 released. No more queue littering Mads Martin Joergensen
  2005-05-09  7:16 ` Mads Martin Joergensen
  2005-05-09 12:47 ` Jakob Hirsch
@ 2005-05-09 12:48 ` Mads Martin Joergensen
  2 siblings, 0 replies; 4+ messages in thread
From: Mads Martin Joergensen @ 2005-05-09 12:48 UTC (permalink / raw)
  To: mlmmj

* Jakob Hirsch <jh@plonk.de> [May 09. 2005 14:47]:
> >+                               subject_present = 1;
> 
> It's there (a few lines below), but will only be done if the subject 
> contains the prefix, which is obiously wrong.
> sorry for that.

No worries--I've made .1 releases before :-)

> the extra setting of subject_present doesn't hurt, but for clarity, it's 
> better to remove it:
> 
> --- do_all_the_voodo_here.c   2005-05-08 18:18:02 +0200
> +++ do_all_the_voodo_here.c   2005-05-09 14:41:41 +0200
> @@ -153,7 +154,6 @@
>                                         myfree(subject);
>                                         myfree(hdrline);
>                                         myfree(unqp);
> -                                       subject_present = 1;
>                                         continue;
>                                 }
>                                 myfree(unqp);

Yeah.

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2005-05-09 12:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-08 18:26 1.2.6 released. No more queue littering Mads Martin Joergensen
2005-05-09  7:16 ` Mads Martin Joergensen
2005-05-09 12:47 ` Jakob Hirsch
2005-05-09 12:48 ` Mads Martin Joergensen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox