* + staging-rt2860-use-new-hex_to_bin-method.patch added to -mm tree
@ 2010-04-30 19:02 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2010-04-30 19:02 UTC (permalink / raw)
To: mm-commits; +Cc: ext-andriy.shevchenko, gregkh
The patch titled
staging: rt2860: use new hex_to_bin() method
has been added to the -mm tree. Its filename is
staging-rt2860-use-new-hex_to_bin-method.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: staging: rt2860: use new hex_to_bin() method
From: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Instead of using own implementation involve hex_to_bin() function.
Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/staging/rt2860/common/rtmp_init.c | 15 ++-------------
drivers/staging/rt2860/rtmp.h | 2 --
2 files changed, 2 insertions(+), 15 deletions(-)
diff -puN drivers/staging/rt2860/common/rtmp_init.c~staging-rt2860-use-new-hex_to_bin-method drivers/staging/rt2860/common/rtmp_init.c
--- a/drivers/staging/rt2860/common/rtmp_init.c~staging-rt2860-use-new-hex_to_bin-method
+++ a/drivers/staging/rt2860/common/rtmp_init.c
@@ -2810,17 +2810,6 @@ void UserCfgInit(struct rt_rtmp_adapter
}
/* IRQL = PASSIVE_LEVEL */
-u8 BtoH(char ch)
-{
- if (ch >= '0' && ch <= '9')
- return (ch - '0'); /* Handle numerals */
- if (ch >= 'A' && ch <= 'F')
- return (ch - 'A' + 0xA); /* Handle capitol hex digits */
- if (ch >= 'a' && ch <= 'f')
- return (ch - 'a' + 0xA); /* Handle small hex digits */
- return (255);
-}
-
/* */
/* FUNCTION: AtoH(char *, u8 *, int) */
/* */
@@ -2847,8 +2836,8 @@ void AtoH(char *src, u8 *dest, int destl
destTemp = (u8 *)dest;
while (destlen--) {
- *destTemp = BtoH(*srcptr++) << 4; /* Put 1st ascii byte in upper nibble. */
- *destTemp += BtoH(*srcptr++); /* Add 2nd ascii byte to above. */
+ *destTemp = hex_to_bin(*srcptr++) << 4; /* Put 1st ascii byte in upper nibble. */
+ *destTemp += hex_to_bin(*srcptr++); /* Add 2nd ascii byte to above. */
destTemp++;
}
}
diff -puN drivers/staging/rt2860/rtmp.h~staging-rt2860-use-new-hex_to_bin-method drivers/staging/rt2860/rtmp.h
--- a/drivers/staging/rt2860/rtmp.h~staging-rt2860-use-new-hex_to_bin-method
+++ a/drivers/staging/rt2860/rtmp.h
@@ -2356,8 +2356,6 @@ void RTMPMoveMemory(void *pDest, void *p
void AtoH(char *src, u8 *dest, int destlen);
-u8 BtoH(char ch);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-04-30 19:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-30 19:02 + staging-rt2860-use-new-hex_to_bin-method.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox