Linux MM tree latest commits
 help / color / mirror / Atom feed
* + mm-memcontrol-uninitialised-return-value.patch added to -mm tree
@ 2010-05-06 21:24 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2010-05-06 21:24 UTC (permalink / raw)
  To: mm-commits; +Cc: ext-phil.2.carmody, balbir, kamezawa.hiroyu, kirill, nishimura


The patch titled
     mm: memcontrol - uninitialised return value
has been added to the -mm tree.  Its filename is
     mm-memcontrol-uninitialised-return-value.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: mm: memcontrol - uninitialised return value
From: Phil Carmody <ext-phil.2.carmody@nokia.com>

Only an out of memory error will cause ret to be set.

Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
Acked-by: Kirill A. Shutemov <kirill@shutemov.name>
Cc: Balbir Singh <balbir@in.ibm.com>
Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/memcontrol.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN mm/memcontrol.c~mm-memcontrol-uninitialised-return-value mm/memcontrol.c
--- a/mm/memcontrol.c~mm-memcontrol-uninitialised-return-value
+++ a/mm/memcontrol.c
@@ -3598,7 +3598,7 @@ static int mem_cgroup_usage_unregister_e
 	int type = MEMFILE_TYPE(cft->private);
 	u64 usage;
 	int size = 0;
-	int i, j, ret;
+	int i, j, ret = 0;
 
 	mutex_lock(&memcg->thresholds_lock);
 	if (type == _MEM)
_

Patches currently in -mm which might be from ext-phil.2.carmody@nokia.com are

linux-next.patch
errh-add-__must_check-to-error-pointer-handlers.patch
hvsi-messed-up-error-checking-getting-state-name.patch
mm-remove-unnecessary-use-of-atomic.patch
mm-memcontrol-uninitialised-return-value.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-05-06 21:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-06 21:24 + mm-memcontrol-uninitialised-return-value.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox