Linux MM tree latest commits
 help / color / mirror / Atom feed
* + padata-add-parenthesis-in-max_seq_nr-macro.patch added to -mm tree
@ 2010-05-26 23:28 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2010-05-26 23:28 UTC (permalink / raw)
  To: mm-commits; +Cc: error27, herbert, steffen.klassert


The patch titled
     padata: add parenthesis in MAX_SEQ_NR macro
has been added to the -mm tree.  Its filename is
     padata-add-parenthesis-in-max_seq_nr-macro.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: padata: add parenthesis in MAX_SEQ_NR macro
From: Dan Carpenter <error27@gmail.com>

MAX_SEQ_NR is used in padata_alloc_pd() like this:

        pd->max_seq_nr = (MAX_SEQ_NR / num_cpus) * num_cpus - 1;

It needs parenthesis or the divide by num_cpus takes precedence over the
subtraction.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Herbert Xu <herbert@gondor.hengli.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/padata.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN kernel/padata.c~padata-add-parenthesis-in-max_seq_nr-macro kernel/padata.c
--- a/kernel/padata.c~padata-add-parenthesis-in-max_seq_nr-macro
+++ a/kernel/padata.c
@@ -28,7 +28,7 @@
 #include <linux/slab.h>
 #include <linux/rcupdate.h>
 
-#define MAX_SEQ_NR INT_MAX - NR_CPUS
+#define MAX_SEQ_NR (INT_MAX - NR_CPUS)
 #define MAX_OBJ_NUM 1000
 
 static int padata_index_to_cpu(struct parallel_data *pd, int cpu_index)
_

Patches currently in -mm which might be from error27@gmail.com are

origin.patch
proc-cleanup-remove-unused-assignments.patch
linux-next.patch
mtd-sst25l-check-for-null-consistently.patch
scsi-remove-superfluous-null-pointer-check-from-scsi_kill_request.patch
padata-add-parenthesis-in-max_seq_nr-macro.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-05-26 23:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-26 23:28 + padata-add-parenthesis-in-max_seq_nr-macro.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox