Linux MM tree latest commits
 help / color / mirror / Atom feed
* + rtc-s3c-initialize-driver-data-before-using-it.patch added to -mm tree
@ 2010-05-27 21:53 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2010-05-27 21:53 UTC (permalink / raw)
  To: mm-commits; +Cc: mcuelenaere, a.zummo, p_gortmaker, stable


The patch titled
     rtc: s3c: initialize driver data before using it
has been added to the -mm tree.  Its filename is
     rtc-s3c-initialize-driver-data-before-using-it.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: rtc: s3c: initialize driver data before using it
From: Maurus Cuelenaere <mcuelenaere@gmail.com>

s3c_rtc_setfreq() uses the platform driver data to derive struct rtc_device,
so make sure drvdata is set _before_ s3c_rtc_setfreq() is called.

Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
Cc: Paul Gortmaker <p_gortmaker@yahoo.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Maurus Cuelenaere <mcuelenaere@gmail.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/rtc/rtc-s3c.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff -puN drivers/rtc/rtc-s3c.c~rtc-s3c-initialize-driver-data-before-using-it drivers/rtc/rtc-s3c.c
--- a/drivers/rtc/rtc-s3c.c~rtc-s3c-initialize-driver-data-before-using-it
+++ a/drivers/rtc/rtc-s3c.c
@@ -495,8 +495,6 @@ static int __devinit s3c_rtc_probe(struc
  	pr_debug("s3c2410_rtc: RTCCON=%02x\n",
 		 readb(s3c_rtc_base + S3C2410_RTCCON));
 
-	s3c_rtc_setfreq(&pdev->dev, 1);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-05-27 21:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-27 21:53 + rtc-s3c-initialize-driver-data-before-using-it.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox