Linux MM tree latest commits
 help / color / mirror / Atom feed
* + rtc-s3c-initialize-s3c_rtc_cpu_type-before-using-it.patch added to -mm tree
@ 2010-05-27 21:53 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2010-05-27 21:53 UTC (permalink / raw)
  To: mm-commits; +Cc: mcuelenaere, a.zummo, jiri.pinkava, p_gortmaker


The patch titled
     rtc: s3c: initialize s3c_rtc_cpu_type before using it
has been added to the -mm tree.  Its filename is
     rtc-s3c-initialize-s3c_rtc_cpu_type-before-using-it.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: rtc: s3c: initialize s3c_rtc_cpu_type before using it
From: Maurus Cuelenaere <mcuelenaere@gmail.com>

Make sure s3c_rtc_cpu_type is initialised _before_ it's used in an if()
check.

Reported-by: Jiri Pinkava <jiri.pinkava@vscht.cz>
Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
Cc: Paul Gortmaker <p_gortmaker@yahoo.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Maurus Cuelenaere <mcuelenaere@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/rtc/rtc-s3c.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -puN drivers/rtc/rtc-s3c.c~rtc-s3c-initialize-s3c_rtc_cpu_type-before-using-it drivers/rtc/rtc-s3c.c
--- a/drivers/rtc/rtc-s3c.c~rtc-s3c-initialize-s3c_rtc_cpu_type-before-using-it
+++ a/drivers/rtc/rtc-s3c.c
@@ -508,13 +508,13 @@ static int __devinit s3c_rtc_probe(struc
 		goto err_nortc;
 	}
 
+	s3c_rtc_cpu_type = platform_get_device_id(pdev)->driver_data;
+
 	if (s3c_rtc_cpu_type == TYPE_S3C64XX)
 		rtc->max_user_freq = 32768;
 	else
 		rtc->max_user_freq = 128;
 
-	s3c_rtc_cpu_type = platform_get_device_id(pdev)->driver_data;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-05-27 21:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-27 21:53 + rtc-s3c-initialize-s3c_rtc_cpu_type-before-using-it.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox