Linux MM tree latest commits
 help / color / mirror / Atom feed
* + vt-fix-region-clearing.patch added to -mm tree
@ 2010-05-28 23:10 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2010-05-28 23:10 UTC (permalink / raw)
  To: mm-commits; +Cc: frankpzh, alan, catalin.marinas, daniel, gregkh


The patch titled
     vt: fix region clearing
has been added to the -mm tree.  Its filename is
     vt-fix-region-clearing.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: vt: fix region clearing
From: Frank Pan <frankpzh@gmail.com>

The code uses vc->vc_cols instead of vc->vc_size_row by mistake, it will
cause half of the region which is going to clear remain uncleared.  The
issue happens in background consoles, so it's hard to observe.

Signed-off-by: Frank Pan <frankpzh@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Daniel Mack <daniel@caiaq.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/char/vt.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/char/vt.c~vt-fix-region-clearing drivers/char/vt.c
--- a/drivers/char/vt.c~vt-fix-region-clearing
+++ a/drivers/char/vt.c
@@ -304,7 +304,7 @@ static void scrup(struct vc_data *vc, un
 	d = (unsigned short *)(vc->vc_origin + vc->vc_size_row * t);
 	s = (unsigned short *)(vc->vc_origin + vc->vc_size_row * (t + nr));
 	scr_memmovew(d, s, (b - t - nr) * vc->vc_size_row);
-	scr_memsetw(d + (b - t - nr) * vc->vc_cols, vc->vc_video_erase_char,
+	scr_memsetw(d + (b - t - nr) * vc->vc_size_row, vc->vc_video_erase_char,
 		    vc->vc_size_row * nr);
 }
 
_

Patches currently in -mm which might be from frankpzh@gmail.com are

vt-fix-region-clearing.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-05-28 23:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-28 23:10 + vt-fix-region-clearing.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox