* + flat-fix-unmap-len-in-load-error-path.patch added to -mm tree
@ 2010-05-28 23:26 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2010-05-28 23:26 UTC (permalink / raw)
To: mm-commits; +Cc: vapier, davidm, dhowells, geert, gerg, lethal, monstr, takata
The patch titled
flat: fix unmap len in load error path
has been added to the -mm tree. Its filename is
flat-fix-unmap-len-in-load-error-path.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: flat: fix unmap len in load error path
From: Mike Frysinger <vapier@gentoo.org>
The data chunk is mmaped with 'len' which remains unchanged, so use that
when unmapping in the error path rather than trying to recalculate (and
incorrectly so) the value used originally.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Acked-by: David McCullough <davidm@snapgear.com>
Acked-by: Greg Ungerer <gerg@uclinux.org>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Michal Simek <monstr@monstr.eu>
Cc: Hirokazu Takata <takata@linux-m32r.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/binfmt_flat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN fs/binfmt_flat.c~flat-fix-unmap-len-in-load-error-path fs/binfmt_flat.c
--- a/fs/binfmt_flat.c~flat-fix-unmap-len-in-load-error-path
+++ a/fs/binfmt_flat.c
@@ -596,7 +596,7 @@ static int load_flat_file(struct linux_b
if (IS_ERR_VALUE(result)) {
printk("Unable to read data+bss, errno %d\n", (int)-result);
do_munmap(current->mm, textpos, text_len);
- do_munmap(current->mm, realdatastart, data_len + extra);
+ do_munmap(current->mm, realdatastart, len);
ret = result;
goto err;
}
_
Patches currently in -mm which might be from vapier@gentoo.org are
origin.patch
linux-next.patch
flat-split-the-stack-data-alignments.patch
flat-tweak-default-stack-alignment.patch
flat-fix-unmap-len-in-load-error-path.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-05-28 23:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-28 23:26 + flat-fix-unmap-len-in-load-error-path.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox